-
Notifications
You must be signed in to change notification settings - Fork 56
[Draft PR, NOT review] improve mixed data type performance #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#endif | ||
|
||
template <class T, class = void> | ||
struct ScaleType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same. And this should be a type alias.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you marks this as resolved. you didn't address it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we talked before, i will make this PR as draft because peter's PR may cover my improvement. i will re-check this PR after peter's PR merged.
Some of the comments should really go into #472. You should not upload PRs depending on other PRs and ask for review. |
@taozha2 Do you have some performance data we can look at? |
@rolandschulz @petercad
And this is before:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure all comments are addressed
sorry. forgot. thanks for changing to draft. |
No description provided.