Skip to content

Support fp32 accumulation for bf16 gemm and grouped gemm #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Support fp32 accumulation for bf16 gemm and grouped gemm #482

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4736337
support fp32 accumulation for bf16 gemm and grouped gemm
wuxun-zhang Aug 27, 2025
a8aefe0
updates
wuxun-zhang Aug 29, 2025
8b36b71
address comment
wuxun-zhang Sep 2, 2025
0d733e8
support different accumulator dtype combinations
wuxun-zhang Sep 3, 2025
04e3da0
fix example
wuxun-zhang Sep 3, 2025
a1a6121
fix tests
wuxun-zhang Sep 3, 2025
3998cb9
Merge branch 'main' into wuxun/bf16-out-gemm
rolandschulz Sep 4, 2025
28cb9fb
Merge branch 'main' into wuxun/bf16-out-gemm
tdeng5 Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions include/cutlass/epilogue/collective/xe_array_epilogue.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,8 @@ class CollectiveEpilogue<
using DispatchPolicy = IntelXeXMX16Group;
using CtaTileMNK = CtaTileMNK_;
using FusionCallbacks = FusionCallbacks_;
using ElementC = ElementD_;
// simple use fp32 as accumulator dtype
using ElementAccumulator = float;
using ElementC = typename FusionCallbacks::ElementSource;
using ElementAccumulator = ElementC_;
Copy link

@sanchitintel sanchitintel Sep 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config did not work with the latest commit of this branch. Is it currently supported? Thanks!

image

using StrideC = StrideC_;
using InternalStrideC = cute::remove_pointer_t<StrideC>;
using ElementD = ElementD_;
Expand Down
6 changes: 2 additions & 4 deletions include/cutlass/epilogue/collective/xe_epilogue.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,8 @@ class CollectiveEpilogue<
using DispatchPolicy = IntelXeXMX16;
using CtaTileMNK = CtaTileMNK_;
using FusionCallbacks = FusionCallbacks_;
// assume C and D have same dtype
using ElementC = ElementD_;
// simple use fp32 as accumulator dtype
using ElementAccumulator = float;
using ElementC = typename FusionCallbacks::ElementSource;;
using ElementAccumulator = ElementC_;
using StrideC = StrideC_;
using ElementD = ElementD_;
using StrideD = StrideD_;
Expand Down