Use newer version of mma_atom and copy_atom in CollectiveEpilogue for 00_bmg_gemm test #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petercad
reviewed
Oct 15, 2025
petercad
reviewed
Oct 15, 2025
petercad
reviewed
Oct 15, 2025
| if constexpr (!std::is_void_v<CopyOpG2R>) { | ||
| return make_block_2d_copy_A(CopyOpG2R{}, tiled_mma, mC(_,_,0)); | ||
| } else { | ||
| return make_block_2d_copy_A(tiled_mma, mC(_,_,0)); |
There was a problem hiding this comment.
This works "by accident" for f16/bf16 A, but let's add a version of make_block_2d_copy_C that can handle loads. I will send you a patch for that.
petercad
reviewed
Oct 15, 2025
Antonyvance
added
release
urgent
taozha2
reviewed
Oct 20, 2025
| for (int epi_v = 0; epi_v < size<0>(trD_compute_frag); ++epi_v) { | ||
| trD_compute_frag(epi_v) = cst_callbacks.visit(acc_frag_mn(epi_v), epi_v, epi_m, epi_n); | ||
| for (int f = 0; f < FragmentSize; ++f) { | ||
| trD_compute_frag[f] = trD_compute(epi_v * FragmentSize + f); |
There was a problem hiding this comment.
why move data here? can we dirrectly access trD_compute?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #540 modernizes the collectivemma module by replacing legacy atoms with their updated counterparts.
The current PR focuses on updating the collectiveEpilogue module with similar improvements. However, PR #540 must be merged first as the collectiveEpilogue changes depend on the atom updates introduced in that pull request.