Skip to content

Conversation

@zhengchenyu
Copy link
Contributor

What changes were proposed in this pull request?

Support py_volcano platform.

Why are the changes needed?

See #1559 for details.

Does this PR introduce any user-facing change?

See #1559 for details.

How was this patch tested?

test in real cluster.

@zhengchenyu zhengchenyu marked this pull request as draft May 29, 2025 09:29
@codecov
Copy link

codecov bot commented May 29, 2025

Codecov Report

❌ Patch coverage is 12.50000% with 112 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.64%. Comparing base (f3f876b) to head (c61adec).

Files with missing lines Patch % Lines
dlrover/python/scheduler/volcano.py 0.00% 52 Missing ⚠️
dlrover/trainer/torch/elastic_run.py 16.66% 25 Missing ⚠️
dlrover/python/master/watcher/volcano_watcher.py 0.00% 10 Missing ⚠️
dlrover/python/master/scaler/volcano_scaler.py 0.00% 9 Missing ⚠️
dlrover/python/scheduler/factory.py 0.00% 6 Missing ⚠️
dlrover/python/master/scaler/factory.py 0.00% 3 Missing ⚠️
dlrover/python/master/watcher/factory.py 25.00% 3 Missing ⚠️
dlrover/python/elastic_agent/torch/training.py 50.00% 2 Missing ⚠️
dlrover/python/master/main.py 33.33% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (12.50%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1560      +/-   ##
==========================================
- Coverage   80.04%   79.64%   -0.41%     
==========================================
  Files         228      231       +3     
  Lines       22117    22242     +125     
==========================================
+ Hits        17704    17715      +11     
- Misses       4413     4527     +114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalaBalaYi
Copy link
Collaborator

@zhengchenyu may i have ur email plz? looking for more coop

@zhengchenyu
Copy link
Contributor Author

@zhengchenyu may i have ur email plz? looking for more coop

I have join the dingtalk group for more coop.

@zhengchenyu zhengchenyu deleted the pyvolcano branch September 24, 2025 11:29
@zhengchenyu zhengchenyu changed the title support py_volcano platform support volcano platform Sep 24, 2025
@zhengchenyu
Copy link
Contributor Author

Update to the using version.
This version no longer relies on developing the dlrover plugin on volcano, and only requires setting the svc and env plugins on the volcano job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants