Skip to content

Avoiding socket file conflicts #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

Avoiding socket file conflicts #1643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions dlrover/python/common/multi_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

import _posixshmem

from . import env_utils
from .constants import NodeEnv
from .log import default_logger as logger

Expand Down Expand Up @@ -217,10 +218,11 @@ def _create_socket_path(self):
"""Create a file path for the local socket."""
fname = self.__class__.__name__.lower() + "_" + self._name + ".sock"
job_name = os.getenv(NodeEnv.TORCHELASTIC_RUN_ID, "")
node_rank = env_utils.get_node_rank()
if job_name:
root_dir = os.path.join(SOCKET_TMP_DIR, job_name)
root_dir = os.path.join(SOCKET_TMP_DIR, job_name, str(node_rank))
else:
root_dir = SOCKET_TMP_DIR
root_dir = os.path.join(SOCKET_TMP_DIR, str(node_rank))
os.makedirs(root_dir, exist_ok=True)
return os.path.join(root_dir, fname)

Expand Down