fix(analyzers): raise configuration exception for non-email GENERIC observables in HudsonRock. Closes #3647#3655
Open
Nehall1 wants to merge 6 commits intointelowlproject:masterfrom
Open
Conversation
…oject#3624) * updated PR automation Slow run to avoid executing all the optional containers * update history routing constants to fix broken tabs --------- Co-authored-by: Daniele Rosetti <55402684+drosetti@users.noreply.github.com> Co-authored-by: Matteo Lodi <30625432+mlodic@users.noreply.github.com>
…project#3621) (intelowlproject#3625) * fix: patch peframe tostring() for Python 3.9+ compatibility (intelowlproject#3621) * add comment explaining peframe tostring patch
…lowlproject#3571 (intelowlproject#3579) * fix(connectors): eliminate N+1 HTTP requests in MISP connector * test(connectors): add unit tests for MISP bulk add_event
* refactor: remove Greynoise_Labs analyzer * chore: delete associated periodic tasks
Nehall1
force-pushed
the
fix/hudsonrock-generic-crash
branch
3 times, most recently
from
afb9f6c to
dd190bf
Compare
…bservables in HudsonRock. Closes intelowlproject#3647
Nehall1
force-pushed
the
fix/hudsonrock-generic-crash
branch
from
dd190bf to
6480eba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the HudsonRock analyzer is given a
GENERICobservable that is not an email, the analyzer currently skips the network request but attempts to callresponse.raise_for_status()on an empty dictionary, fatally crashing the worker.This PR resolves the bug by explicitly raising an
AnalyzerConfigurationExceptionwhen an invalid GENERIC observable is provided.elsefallback clause inhudsonrock.pytest_invalid_generic_raises_exceptionto HudsonRock's test suite to assert the exception.Closes #3647
Type of change
Checklist
develop