Skip to content

Update dependency eslint to v10 - #7

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/major-eslint-monorepo
Open

Update dependency eslint to v10#7
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/major-eslint-monorepo

Conversation

@renovate

@renovate renovate Bot commented Oct 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

ℹ️ Note

This PR body was truncated due to platform limits.

This PR contains the following updates:

Package Change Age Confidence
eslint (source) ^8.18.0 → ^10.0.0 age confidence

Release Notes

eslint/eslint (eslint)

v10.10.0

Compare Source

v10.9.1

Compare Source

v10.9.0

Compare Source

v10.8.1

Compare Source

Bug Fixes

  • 18eb0a7 fix: prevent ASI hazard in no-unused-labels autofix (#​21173) (dongkyu lee)
  • 151ba3f fix: false positives in getter-return and accessor-pairs (#​21163) (Grit)
  • 6898df9 fix: ignore meta-property names in id-denylist (#​21166) (Pixel)
  • 4d7db66 fix: ignore meta-property names in id-match (#​21167) (Pixel)
  • 677214e fix: handle ASI hazards in no-unused-vars removeVar suggestion (#​20935) (kuldeep kumar)

Documentation

  • 7d0cbf8 docs: Update README (GitHub Actions Bot)
  • 0a05812 docs: add missing backticks to no-duplicate-imports.js (#​21183) (Lee Daeun)
  • 678c90b docs: Update README (GitHub Actions Bot)
  • 8a10424 docs: Update README (GitHub Actions Bot)
  • 69bb948 docs: Update README (GitHub Actions Bot)

Chores

v10.8.0

Compare Source

Features

Bug Fixes

  • 6b8d2f7 fix: escape reserved characters in rule id in html formatter (#​21129) (Francesco Trotta)
  • 9091071 fix: prevent no-unreachable-loop crash when all loop types are ignored (#​21116) (Pixel)
  • e23fafe fix: prefer-object-spread add semicolon when adding parenthesis (#​21081) (synthex-byte)
  • 20b5ad0 fix: quadratic-time regex in prefer-template (#​21096) (Milos Djermanovic)
  • 8b6f6c0 fix: apply ignore configs to computed methods in class-methods-use-this (#​21094) (Pixel)
  • b2c608c fix: NewExpression with parenthesized callee in preserve-caught-error (#​21083) (Francesco Trotta)

Documentation

  • 6ddf858 docs: fix broken Specify Parser Options anchor link (#​21106) (Minsu)
  • 784dfbe docs: Clarify no-eq-null description (#​21120) (Park Harin)
  • 7ec733a docs: Fix typos and grammar in glossary (#​21095) (Marry (Subin Yang))
  • 92bb13f docs: replace quake link (#​21108) (Jung Hyeon Jun)
  • 68eb4a5 docs: fix broken Specify Globals anchor links in rule pages (#​21103) (Minsu)
  • d28f697 docs: replace Code Climate CLI links with Qlty CLI links (#​21099) (Jung Hyeon Jun)
  • eccc68d docs: correct --suppressions-location option description (#​21093) (Ga eun Lee)
  • c5963f7 docs: Update README (GitHub Actions Bot)

Chores

  • 4fbf46d test: pin webpack version to 5.108.4 (#​21137) (Francesco Trotta)
  • 2d063e2 chore: update HTTP URLs to HTTPS in JSDoc and comments (#​21101) (Bo Hyun Kim)
  • eccbe7b test: add error locations to no-class-assign (#​21123) (devoil)
  • e7d1e43 ci: bump actions/setup-go from 6 to 7 (#​21118) (dependabot[bot])
  • e9d66d0 ci: bump actions/setup-node from 6 to 7 (#​21119) (dependabot[bot])
  • ee225b6 test: Add error location details to no-eq-null rule (#​21117) (Park Harin)
  • 044a627 chore: update minimatch to ^10.2.5 (#​21107) (김채영)
  • fb09aa8 chore: update ecosystem plugins (#​21115) (ESLint Bot)
  • 5abd878 test: add error locations to no-proto (#​21114) (Gihyeon Jeong / 정기현)
  • 9715887 test: Add error location details to no-div-regex (#​21110) (Park Harin)
  • a746ec6 test: add error locations to no-new-wrappers (#​21109) (Gihyeon Jeong / 정기현)
  • 8dde645 test: add error locations to no-ex-assign (#​21102) (devoil)
  • 13ab0ec test: add error locations to no-label-var (#​21098) (Gihyeon Jeong / 정기현)
  • a99906f test: Add error location details to no-delete-var rule (#​21105) (Park Harin)
  • c47e8dc chore: add missing backticks to languages/js/index.js (#​21104) (beeen)
  • 0174428 chore: add missing backticks to translate-cli-options.js (#​21097) (dongkyu lee)
  • 3d36589 chore: add missing backticks to serialization.js (#​21091) (이규환)
  • dcc9312 test: add error locations to eqeqeq (#​21090) (Ga eun Lee)
  • 2710b18 ci: Add explicit permissions to rebuild-docs-sites workflow (#​21089) (Marry (Subin Yang))
  • 5d2f866 chore: update dependency prettier to v3.9.5 (#​21086) (renovate[bot])
  • d584e31 chore: fix failing ecosystem test for eslint-plugin-unicorn (#​21084) (Francesco Trotta)
  • bf3eda0 chore: update ecosystem plugins (#​21079) (ESLint Bot)

v10.7.0

Compare Source

Features

  • cf2a9bf feat: add errorClassNames option to preserve-caught-error rule (#​21032) (sethamus)
  • f8b873a feat: max-nested-callbacks option for constructor callbacks (#​21063) (fnx)
  • 557fde8 feat: support computed Number.parseInt member access in radix rule (#​21041) (Pixel)
  • 0b4a73b feat: add suggestions to no-compare-neg-zero (#​21034) (den$)
  • 96cdd42 feat: report invalid signed numeric radix values in radix rule (#​21030) (Pixel)

Bug Fixes

  • 3e7bf15 fix: apply ignoreClassesWithImplements to class expressions (#​21069) (Pixel)
  • 0d7d70c fix: insert cause outside wrapping parens in preserve-caught-error (#​21062) (Mahin Anowar)
  • 75ec753 fix: handle static template literals in eqeqeq rule (#​21058) (Pixel)
  • b717a22 fix: prevent eqeqeq null option from reporting non-equality operators (#​21057) (Pixel)
  • e35b05f fix: avoid no-invalid-regexp false positive for shadowed RegExp (#​21051) (Pixel)
  • a3172b6 fix: avoid no-control-regex false positive for shadowed RegExp (#​21050) (Pixel)
  • d1f637e fix: parenthesize sequence expression operands in no-implicit-coercion (#​21045) (spokodev)
  • 8859baf fix: avoid prefer-numeric-literals false positive for shadowed globals (#​21047) (한국)
  • a9e5961 fix: use-isnan false positive on shadowed NaN/Number (#​20958) (sethamus)
  • 8a240a7 fix: avoid false positives in radix rule for spread arguments (#​21044) (Pixel)

Documentation

  • c30d808 docs: Update README (GitHub Actions Bot)
  • 5139800 docs: document ESLint migration codemods in v9 and v10 guides (#​20980) (Alex Bit)
  • 04174cb docs: Update README (GitHub Actions Bot)
  • 026e130 docs: update semver policy for bug fixes (#​21048) (Milos Djermanovic)
  • 9d42fef docs: Update README (GitHub Actions Bot)
  • b230159 docs: Update README (GitHub Actions Bot)
  • 0129972 docs: correct **/.js glob to **/*.js in config files guide (#​21036) (EduardF1)

Chores

v10.6.0

Compare Source

Features

  • b1f9106 feat: detect Symbol() and BigInt() in no-constant-binary-expression (#​20981) (Taejin Kim)
  • f291007 feat: add checkRelationalComparisons to no-constant-binary-expression (#​20948) (sethamus)

Bug Fixes

  • 6b05784 fix: prefer-exponentiation-operator invalid autofix at statement start (#​20997) (Milos Djermanovic)
  • bb9eb2a fix: account for shadowed Boolean in no-extra-boolean-cast (#​21013) (den$)
  • 8fd8741 fix: don't report shadowed undefined in radix rule (#​21011) (Pixel)
  • 5784980 fix: don't report shadowed undefined in no-throw-literal (#​21010) (Pixel)
  • 9cd1e6d fix: suppress invalid class suggestion in no-promise-executor-return (#​21008) (Pixel)
  • d4eb2dc fix: don't report shadowed undefined in prefer-promise-reject-errors (#​21006) (Pixel)
  • 2360464 fix: prefer-promise-reject-errors false positives for shadowed Promise (#​21003) (den$)
  • 63d52d2 fix: restore max-classes-per-file report range (#​21002) (Pixel)
  • 7feaff0 fix: callback detection logic for IIFEs in max-nested-callbacks (#​20979) (fnx)
  • 399a2ec fix: don't report inner non-callbacks in max-nested-callbacks (#​20995) (Milos Djermanovic)

Documentation

  • a83683d docs: Update README (GitHub Actions Bot)
  • f5449f9 docs: document userland patterns for global assertionOptions in RuleT… (#​20986) (playgirl)
  • bea49f7 docs: Update README (GitHub Actions Bot)
  • e5f70f9 docs: update code-path diagrams (#​20984) (Tanuj Kanti)
  • 8890c2d docs: add TypeScript config guidance for MCP server (#​20796) (Pierluigi Lenoci)
  • 3eb3d9b docs: Update README (GitHub Actions Bot)
  • c5bb59c docs: Update README (GitHub Actions Bot)
  • eb3c97c docs: fix grammar in prefer-const rule description (#​20983) (lumir)

Chores

v10.5.0

Compare Source

Features

  • 5ca8c52 feat: correct stack tracking in max-nested-callbacks (#​20973) (Pixel998)
  • b565783 feat: report no-with violations at the with keyword (#​20971) (Pixel998)
  • 2ce032f feat: report max-lines-per-function violations at function head (#​20966) (Pixel998)
  • 732cb3e feat: report max-nested-callbacks violations at function head (#​20967) (Pixel998)
  • f9c138a feat: report max-depth violations on keywords (#​20943) (Pixel998)
  • bdb496c feat: correct max-depth handling for else-if chains (#​20944) (Pixel998)
  • c296873 feat: update error loc in max-statements to function header (#​20907) (Taejin Kim)

Documentation

  • 8ae1b5b docs: Update README (GitHub Actions Bot)
  • ca7eb90 docs: update Node.js prerequisites to include ICU support (#​20962) (Francesco Trotta)
  • f99b47a docs: Update README (GitHub Actions Bot)
  • acf03d4 docs: clarify precedence of parserOptions over languageOptions (#​20926) (sethamus)

Chores

v10.4.1

Compare Source

Bug Fixes

  • e557467 fix: update @eslint/plugin-kit version to 0.7.2 (#​20930) (Francesco Trotta)
  • d4ce898 fix: propagate failures from delegated commands (#​20917) (Minh Vu)
  • f4f3507 fix: prefer-arrow-callback invalid autofix with newline after async (#​20916) (kuldeep kumar)
  • c5bc78b fix: false positive for reference in finally block (#​20655) (Tanuj Kanti)
  • 27538c0 fix: add missing CodePath and CodePathSegment types (#​20853) (Pixel998)

Documentation

  • 61b0add docs: remove deprecated rule from related rules of max-params (#​20921) (Tanuj Kanti)
  • 305d5b9 docs: remove deprecated rules from related rules section (#​20911) (Tanuj Kanti)
  • 49b0202 docs: fix display: none of ad (#​20901) (Tanuj Kanti)
  • 9067f94 docs: switch build to Node.js 24 (#​20893) (Milos Djermanovic)
  • c91b041 docs: Update README (GitHub Actions Bot)
  • e349265 docs: clarify semver strings in rule deprecation objects (#​20885) (Milos Djermanovic)

Chores

v10.4.0

Compare Source

Features

  • 1a45ec5 feat: check sequence expressions in for-direction (#​20701) (kuldeep kumar)
  • 450040b feat: add includeIgnoreFile() to eslint/config (#​20735) (Kirk Waiblinger)

Bug Fixes

Documentation

  • 7e52a71 docs: add mention of @eslint-react/eslint-plugin (#​20869) (Pavel)
  • db3468b docs: tweak wording around ambiguous CJS-vs-ESM config (#​20865) (Kirk Waiblinger)
  • 9084664 docs: Update README (GitHub Actions Bot)
  • 9cc7387 docs: Update README (GitHub Actions Bot)
  • 3d7b548 docs: Update README (GitHub Actions Bot)
  • 191ec3c docs: Update README (GitHub Actions Bot)

Chores

  • 6616856 chore: upgrade knip to v6 (#​20875) (Pixel998)
  • d13b084 ci: ensure auto-created PRs run CI (#​20860) (lumir)
  • e71c7af ci: bump pnpm/action-setup from 6.0.5 to 6.0.7 (#​20862) (dependabot[bot])
  • d84393d test: add unit tests for SuppressionsService.applySuppressions() (#​20863) (kuldeep kumar)
  • 24db8cb test: add tests for SuppressionsService.save() (#​20802) (kuldeep kumar)
  • 2ef0549 chore: update ecosystem plugins (#​20857) (github-actions[bot])
  • a429791 ci: remove eslint-webpack-plugin types integration test (#​20668) (Milos Djermanovic)
  • 9e37386 chore: replace recast with range approach in code-sample-minimizer (#​20682) (Copilot)
  • 0dd1f9f test: disable warning for vm.constants.USE_MAIN_CONTEXT_DEFAULT_LOADER (#​20845) (Francesco Trotta)
  • 9da3c7b refactor: remove deprecated meta.language and migrate meta.dialects (#​20716) (Pixel998)
  • 2099ed1 refactor: add meta.defaultOptions to more rules, enable linting (#​20800) (xbinaryx)
  • f1dfbc9 chore: update ecosystem plugins (#​20836) (github-actions[bot])
  • c759413 ci: bump pnpm/action-setup from 6.0.3 to 6.0.5 (#​20843) (dependabot[bot])
  • 5b817d6 test: add unit tests for lib/shared/ast-utils (#​20838) (kuldeep kumar)
  • 1c13ae3 test: add unit tests for lib/shared/severity (#​20835) (kuldeep kumar)

v10.3.0

Compare Source

Features

  • 379571a feat: add suggestions for no-unused-private-class-members (#​20773) (sethamus)

Bug Fixes

  • b6ae5cf fix: handle unavailable require cache (#​20812) (Simon Podlipsky)
  • 6fb3685 fix: rule suggestions cause continuation in class body (#​20787) (Milos Djermanovic)

Documentation

  • 32cc7ab docs: fix typos in docs and comments (#​20809) (Tanuj Kanti)
  • 7f47937 docs: Update README (GitHub Actions Bot)

Chores

  • d32235e ci: use pnpm in eslint-flat-config-utils type integration test (#​20826) (Francesco Trotta)
  • 3ffb14e chore: clean up typos in comments and JSDoc (#​20821) (Pixel998)
  • 22eb58a chore: add missing continue-on-error to ecosystem-tests.yml (#​20818) (Josh Goldberg ✨)
  • 88bf002 ci: bump pnpm/action-setup from 6.0.1 to 6.0.3 (#​20815) (dependabot[bot])
  • 97c8c33 chore: update ilshidur/action-discord action to v0.4.0 (#​20811) (renovate[bot])
  • 2f58136 chore: pin peter-evans/create-pull-request action to 5f6978f (#​20810) (renovate[bot])
  • 77add7f chore: add initial ecosystem plugin tests workflow (#​19643) (Josh Goldberg ✨)
  • 4023b55 test: Add unit tests for SuppressionsService.prune() (#​20797) (kuldeep kumar)
  • 54080da test: add unit tests for ForkContext (#​20778) (kuldeep kumar)
  • f0e2bcc test: add unit tests for SuppressionsService.suppress() method (#​20765) (kuldeep kumar)
  • a7f0b94 chore: update dependency prettier to v3.8.3 (#​20782) (renovate[bot])
  • 7bf93d9 chore: update TypeScript to v6 (#​20677) (sethamus)
  • b42dd72 ci: bump pnpm/action-setup from 6.0.0 to 6.0.1 (#​20781) (dependabot[bot])
  • 2b252be test: add unit tests for IdGenerator (#​20775) (kuldeep kumar)

v10.2.1

Compare Source

Bug Fixes

❗ Important

✂ PR body was truncated to here.

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@github-actions

github-actions Bot commented Oct 14, 2024 •
edited
Loading

Copy link
Copy Markdown
PR Preview Action v1.8.0

🚀 View preview at
https://internetarchive.github.io/iaux-monthly-giving-circle/pr/pr-7/

Built to branch gh-pages at 2025-12-31 14:42 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from f38ede8 to b8b4780 Compare December 11, 2024 18:49
@renovate

renovate Bot commented Dec 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm warn Unknown env config "store". This will stop working in the next major version of npm. See `npm help npmrc` for supported config options.
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @babel/eslint-parser@7.25.8
npm warn Found: eslint@10.10.0
npm warn node_modules/eslint
npm warn   dev eslint@"^10.0.0" from the root project
npm warn   8 more (@eslint-community/eslint-utils, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer eslint@"^7.5.0 || ^8.0.0 || ^9.0.0" from @babel/eslint-parser@7.25.8
npm warn node_modules/@babel/eslint-parser
npm warn   @babel/eslint-parser@"^7.19.1" from @open-wc/eslint-config@9.2.2
npm warn   node_modules/@open-wc/eslint-config
npm warn
npm warn Conflicting peer dependency: eslint@9.39.5
npm warn node_modules/eslint
npm warn   peer eslint@"^7.5.0 || ^8.0.0 || ^9.0.0" from @babel/eslint-parser@7.25.8
npm warn   node_modules/@babel/eslint-parser
npm warn     @babel/eslint-parser@"^7.19.1" from @open-wc/eslint-config@9.2.2
npm warn     node_modules/@open-wc/eslint-config
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @typescript-eslint/eslint-plugin@6.7.3
npm error Found: eslint@10.10.0
npm error node_modules/eslint
npm error   dev eslint@"^10.0.0" from the root project
npm error   peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/eslint-utils@4.4.0
npm error   node_modules/@eslint-community/eslint-utils
npm error     @eslint-community/eslint-utils@"^4.4.0" from @typescript-eslint/utils@6.7.3
npm error     node_modules/@typescript-eslint/utils
npm error       @typescript-eslint/utils@"6.7.3" from @typescript-eslint/eslint-plugin@6.7.3
npm error       node_modules/@typescript-eslint/eslint-plugin
npm error         dev @typescript-eslint/eslint-plugin@"^6.0.0" from the root project
npm error       1 more (@typescript-eslint/type-utils)
npm error   7 more (@open-wc/eslint-config, eslint-plugin-lit-a11y, ...)
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^7.0.0 || ^8.0.0" from @typescript-eslint/eslint-plugin@6.7.3
npm error node_modules/@typescript-eslint/eslint-plugin
npm error   dev @typescript-eslint/eslint-plugin@"^6.0.0" from the root project
npm error
npm error Conflicting peer dependency: eslint@8.57.1
npm error node_modules/eslint
npm error   peer eslint@"^7.0.0 || ^8.0.0" from @typescript-eslint/eslint-plugin@6.7.3
npm error   node_modules/@typescript-eslint/eslint-plugin
npm error     dev @typescript-eslint/eslint-plugin@"^6.0.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry this command with --force or --legacy-peer-deps to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /runner/cache/others/npm/_logs/2026-09-10T16_17_00_021Z-eresolve-report.txt
npm error A complete log of this run can be found in: /runner/cache/others/npm/_logs/2026-09-10T16_17_00_021Z-debug-0.log

@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from b8b4780 to e332a14 Compare July 28, 2025 20:13
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from e332a14 to ce08356 Compare August 9, 2025 03:43
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from ce08356 to c4c5055 Compare September 1, 2025 13:43
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from c4c5055 to e34089c Compare November 16, 2025 11:33
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from e34089c to b028483 Compare December 13, 2025 11:47
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch 2 times, most recently from 0e2cfeb to e3d9383 Compare December 31, 2025 04:30
@iisa

iisa commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

@copilot new branch

Copilot AI commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

@iisa I've opened a new pull request, #54, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI mentioned this pull request Dec 31, 2025
Draft
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch 2 times, most recently from 401af97 to c49c69d Compare December 31, 2025 14:41
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from c49c69d to cbd006c Compare February 7, 2026 00:25
@renovate renovate Bot changed the title Update dependency eslint to v9 Update dependency eslint to v10 Feb 7, 2026
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from cbd006c to 0fb2a07 Compare February 20, 2026 17:31
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from 0fb2a07 to 3f6a58e Compare March 5, 2026 18:06
@renovate renovate Bot changed the title Update dependency eslint to v10 chore(deps): update dependency eslint to v10 Mar 17, 2026
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch 2 times, most recently from bffae01 to 9a45411 Compare March 27, 2026 13:23
@renovate renovate Bot changed the title chore(deps): update dependency eslint to v10 Update dependency eslint to v10 Apr 8, 2026
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from 9a45411 to 08dff9a Compare April 17, 2026 21:01
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from 08dff9a to 51b506c Compare May 12, 2026 13:05
@renovate renovate Bot changed the title Update dependency eslint to v10 Update eslint monorepo to v10 Jun 2, 2026
@renovate renovate Bot changed the title Update eslint monorepo to v10 Update eslint monorepo (major) Jun 22, 2026
@renovate renovate Bot changed the title Update eslint monorepo (major) Update dependency eslint to v10 Jun 25, 2026
iisa added a commit that referenced this pull request Jul 16, 2026
@iisa @claude
refactor: unify payment submit flow + address PR #80 review feedback
dbbd94e 
Rework the edit-payment-method submit into one always-visible button with a
consistent enabled state across providers, and resolve jbuckner's review
comments.

Unified submit flow (payment-method.ts):
- One submit button (#edit-plan-payment-method-submit), always visible while
  editing. Enabled when Credit Card is selected, or once a wallet provider
  (PayPal/Venmo/Apple Pay/Google Pay) has authorized.
- Wallet authorized callbacks capture the request in new
  `authorizedPaymentMethodRequest` state instead of dispatching; the submit
  click dispatches UpdatePaymentMethod (Credit Card validates its fields first).
- selectProvider() clears the captured request on every provider
  switch/reset/cancel/success so a stale nonce can't be submitted.
- Authorization triggers are unchanged: PayPal's SDK button and Venmo's button,
  GP/AP launch on selection, Apple Pay launches synchronously off the click.

Review comments:
- #2 Simplify displayBraintreeManager to !!selectedPaymentProvider.
- #4 Drop GP/AP setNewPaymentMethod calls; the update is owned by the submit +
  host, consistent with the other providers.
- #6 Convert setNewPaymentMethod's if/else chain to a switch on paymentProvider.
- #7 Show the "Expires:" line from expiration-data presence instead of an
  exclusion list; drops the "month not found" line for PayPal/Venmo.
- #3/#5/#8 No code change (Google Pay CANCELED status code and the Apple Pay
  init/originalEvent are correct as-is; explained in the review replies).

Tests: wallet tests now assert authorize -> enable submit -> submit -> dispatch;
"submit hidden" tests become "visible + disabled until authorized"; drop the two
"updates the plan model immediately" tests (behavior removed); add
Expires-absent tests for PayPal/Venmo. 212 passing.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
iisa added a commit that referenced this pull request Jul 16, 2026
@iisa @claude
New payment method options: Applepay and googlepay (#80)
fc470bf 
* feat: add Google Pay vault flow for editing payment method

- Tokenize and vault a Google Pay card via Braintree, triggered
  immediately on selection (matches PayPal's one-click pattern)
- Update the Plan model at the callback point so the plans list
  reflects the new card without waiting on a host round-trip
- Fix plans-list payment display to show card type + last four
  digits for both Google Pay and credit cards (was previously
  silently broken by a paymentMethodType casing mismatch), and
  stop showing a bogus "Expires: month not found" for Google Pay
- Add demo mocks and a seed plan for exercising the flow locally

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* feat: add Apple Pay vault flow for editing payment method

- Hand-roll ApplePaySession orchestration instead of reusing the
  donation-form package's handler, which always submits a real
  donation on authorization
- Update the Plan model immediately at the callback, matching the
  Google Pay flow
- Add a demo-only Apple Pay simulation for testing outside Safari

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* feat: add force-show + simulate Google Pay demo toggle

Mirrors the existing Apple Pay simulation checkbox so the real
startGooglePayPayment() code path can be exercised end-to-end in any
browser, since the demo's placeholder merchant ID otherwise leaves
Google Pay perpetually unavailable.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* refactor: unify payment submit flow + address PR #80 review feedback

Rework the edit-payment-method submit into one always-visible button with a
consistent enabled state across providers, and resolve jbuckner's review
comments.

Unified submit flow (payment-method.ts):
- One submit button (#edit-plan-payment-method-submit), always visible while
  editing. Enabled when Credit Card is selected, or once a wallet provider
  (PayPal/Venmo/Apple Pay/Google Pay) has authorized.
- Wallet authorized callbacks capture the request in new
  `authorizedPaymentMethodRequest` state instead of dispatching; the submit
  click dispatches UpdatePaymentMethod (Credit Card validates its fields first).
- selectProvider() clears the captured request on every provider
  switch/reset/cancel/success so a stale nonce can't be submitted.
- Authorization triggers are unchanged: PayPal's SDK button and Venmo's button,
  GP/AP launch on selection, Apple Pay launches synchronously off the click.

Review comments:
- #2 Simplify displayBraintreeManager to !!selectedPaymentProvider.
- #4 Drop GP/AP setNewPaymentMethod calls; the update is owned by the submit +
  host, consistent with the other providers.
- #6 Convert setNewPaymentMethod's if/else chain to a switch on paymentProvider.
- #7 Show the "Expires:" line from expiration-data presence instead of an
  exclusion list; drops the "month not found" line for PayPal/Venmo.
- #3/#5/#8 No code change (Google Pay CANCELED status code and the Apple Pay
  init/originalEvent are correct as-is; explained in the review replies).

Tests: wallet tests now assert authorize -> enable submit -> submit -> dispatch;
"submit hidden" tests become "visible + disabled until authorized"; drop the two
"updates the plan model immediately" tests (behavior removed); add
Expires-absent tests for PayPal/Venmo. 212 passing.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from 51b506c to 1bd338e Compare July 21, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iisa