subcommunities: improve search page by alejandromumo · Pull Request #1242 · inveniosoftware/invenio-communities

alejandromumo · 2024-10-23T22:32:59Z

Anonymous user

Authenticated user

** Smaller screens ªª

alejandromumo · 2024-10-23T22:37:59Z

...io_communities/assets/semantic-ui/js/invenio_communities/subcommunity/SubcommunityResults.js

@@ -0,0 +1,75 @@
+// This file is part of Invenio


This file is almost the same as https://github.com/inveniosoftware/invenio-requests/blob/master/invenio_requests/assets/semantic-ui/js/invenio_requests/search/RequestsResults.js (just renamed it). That makes me think this can be moved to a higher module so both requests and communities can reuse it.

Maybe also in react-invenio-forms?

this is a search aware component, we should move it to invenio-search-ui?

this is a search aware component, we should move it to invenio-search-ui?

Exactly, I was just messaging Pablo about this. +1 on moving it to invenio-search-ui

After the discussion, I moved it to a reusable component named invenio_search_ui/components/SearchResultsBox. Not the best name but I'm open to changing it to anything else 😄

However, let's align IRL whether this is the right place / way or not . Ping @ntarocco @ptamarit @kpsherva

The idea was to create a base package, similar to invenio-base for Python code, that serves as a catalog of components. This package should remain stateless, without any specific features or logic, making it a simple dependency that can be included in other modules.

While I understand the rationale behind associating a component that displays search results with invenio-search-ui, I believe that it doesn't align with the intended purpose of the base package.

The base package is meant to be a neutral catalog, and incorporating such a component into invenio-search-ui would go against these criteria.

I am sure that we will find a case where we will need that component in a place where we don't depend on invenio-search-ui.

Happy to hear/read counterarguments.

alejandromumo · 2024-10-23T22:39:15Z

...ts/semantic-ui/js/invenio_communities/community/searchComponents/CommunitySelectionSearch.js

+                    <Menu.Item
+                      as="button"
+                      role="tab"
+                      id="all-communities-tab"
+                      aria-selected={selectedAppId === allCommunities.appId}
+                      aria-controls={allCommunities.appId}
+                      name="All"
+                      active={selectedAppId === allCommunities.appId}
+                      onClick={() =>
+                        this.setState({
+                          selectedConfig: allCommunities,
+                        })
+                      }
+                    >
+                      {i18next.t("All")}
+                    </Menu.Item>
+                    <Menu.Item
+                      as="button"
+                      role="tab"
+                      id="my-communities-tab"
+                      aria-selected={selectedAppId === myCommunities.appId}
+                      aria-controls={myCommunities.appId}


The front-page could reuse this "All / My communities" button. Is it worth moving it to its own component and re-using it? @ptamarit @0einstein0

I've found this to be a bit more complicated since it changes the apiConfig entirely

I think that not showing the buttons to unauthenticated users (as currently done in the front page) would be better. It's more of a convenience than a crucial functionality; if a community owner happens to be logged out, they will still be able to find their community via text search.

That's a good point. Regarding the question "should we make this a reusable component and use it in the frontpage", wdyt?

Yes, right now, this is mostly the same as CommunitySelectionSearch in invenio-rdm-records.
It could go to react-invenio-forms and be used in all 3 places:

The community front page

The subcommunities search

The deposit form community selection

I don't think this component to filter between "All" or "My communities" should be in react-invenio-forms. It's too specific for communities. To be moved even higher in the modules, it had to be more abstract.

I added a reusable component CommunitiesStatusFilter in invenio_communities/community/searchComponents and used it in the 3 places you mentioned.

alejandromumo · 2024-10-23T22:40:27Z

invenio_communities/assets/semantic-ui/js/invenio_communities/subcommunity/search.js

+// eslint-disable-next-line react/no-deprecated
+ReactDOM.render(
+  <Container>
+    <CommunitySelectionSearch


I had to create a component due to the changes of config, based on the selection of "All" or "My communities". I could not connect the config with the component returned by createSearchAppInit, so I created a component that instantiates the search application.

...ts/semantic-ui/js/invenio_communities/community/searchComponents/CommunitySelectionSearch.js

alejandromumo · 2024-10-24T08:16:42Z

invenio_communities/assets/semantic-ui/js/invenio_communities/subcommunity/search.js

+export const overriddenComponents = {
+  [`BucketAggregation.element`]: ContribBucketAggregationElement,
+  [`BucketAggregationValues.element`]: ContribBucketAggregationValuesElement,
+  [`SearchApp.facets`]: ContribSearchAppFacetsWithConfig,
+  [`ResultsList.item`]: CommunityItem,
+  [`ResultsGrid.item`]: ResultsGridItemTemplate,
+  [`SearchBar.element`]: CommunitiesSearchBarElement,
+  [`SearchApp.results`]: SubcommunityResults,


Does it make sense to have the overridden components defined outside the element? Since this is now a "dedicated" search component for subcommunities, perhaps this could be defined in the component itself

If we move the component to react-invenio-forms, we should use props rather than overrideable.

maybe it makes sense to have just one in search ui?
the overridable component exposed from there already has the appName prop ready for you to use

I am not sure I understood what using props means in this context. But let's have a discussion IRL with @ntarocco and @kpsherva to align

ptamarit

Reviewed with @ntarocco

...ts/semantic-ui/js/invenio_communities/community/searchComponents/CommunitySelectionSearch.js

ptamarit · 2024-10-24T13:18:03Z

...ts/semantic-ui/js/invenio_communities/community/searchComponents/CommunitySelectionSearch.js

+                    <Menu.Item
+                      as="button"
+                      role="tab"
+                      id="all-communities-tab"
+                      aria-selected={selectedAppId === allCommunities.appId}
+                      aria-controls={allCommunities.appId}
+                      name="All"
+                      active={selectedAppId === allCommunities.appId}
+                      onClick={() =>
+                        this.setState({
+                          selectedConfig: allCommunities,
+                        })
+                      }
+                    >
+                      {i18next.t("All")}
+                    </Menu.Item>
+                    <Menu.Item
+                      as="button"
+                      role="tab"
+                      id="my-communities-tab"
+                      aria-selected={selectedAppId === myCommunities.appId}
+                      aria-controls={myCommunities.appId}


Yes, right now, this is mostly the same as CommunitySelectionSearch in invenio-rdm-records.
It could go to react-invenio-forms and be used in all 3 places:

The community front page

The subcommunities search

The deposit form community selection

ptamarit · 2024-10-24T13:19:37Z

...io_communities/assets/semantic-ui/js/invenio_communities/subcommunity/SubcommunityResults.js

@@ -0,0 +1,75 @@
+// This file is part of Invenio


Maybe also in react-invenio-forms?

invenio_communities/assets/semantic-ui/js/invenio_communities/subcommunity/index.js

ptamarit · 2024-10-24T13:22:13Z

invenio_communities/assets/semantic-ui/js/invenio_communities/subcommunity/search.js

+export const overriddenComponents = {
+  [`BucketAggregation.element`]: ContribBucketAggregationElement,
+  [`BucketAggregationValues.element`]: ContribBucketAggregationValuesElement,
+  [`SearchApp.facets`]: ContribSearchAppFacetsWithConfig,
+  [`ResultsList.item`]: CommunityItem,
+  [`ResultsGrid.item`]: ResultsGridItemTemplate,
+  [`SearchBar.element`]: CommunitiesSearchBarElement,
+  [`SearchApp.results`]: SubcommunityResults,


If we move the component to react-invenio-forms, we should use props rather than overrideable.

ptamarit · 2024-10-24T13:26:15Z

invenio_communities/assets/semantic-ui/js/invenio_communities/subcommunity/search.js

+    <CommunitySelectionSearch
+      overriddenComponents={overriddenComponents}
+      config={config}
+      userAnonymous={userAnonymous}


For consistency, we can use myCommunitiesEnabled as done in zenodo/zenodo-rdm#1031

I renamed myCommunitiesEnabled to communitiesStatusFilterEnabled since there's a reusable component CommunitiesStatusFilter to toggle between "All" and "My communities".

But followed the same pattern, looks good 😄

...io_communities/assets/semantic-ui/js/invenio_communities/subcommunity/SubcommunityResults.js

alejandromumo added 4 commits October 23, 2024 23:32

subcommunities: improve search page

9967c36

remove console log

7aca22e

chore: update copyright header

eaf7d63

chore: remove logs

6aef16e

alejandromumo commented Oct 23, 2024

View reviewed changes

alejandromumo commented Oct 24, 2024

View reviewed changes

...ts/semantic-ui/js/invenio_communities/community/searchComponents/CommunitySelectionSearch.js Show resolved Hide resolved

alejandromumo commented Oct 24, 2024

View reviewed changes

ptamarit reviewed Oct 24, 2024

View reviewed changes

kpsherva reviewed Oct 24, 2024

View reviewed changes

...io_communities/assets/semantic-ui/js/invenio_communities/subcommunity/SubcommunityResults.js Show resolved Hide resolved

alejandromumo added 4 commits October 24, 2024 16:34

refactor: moved RequestResults to invenio-search-ui

3061252

search: added CommuniitiesStatusFilter component

e118fba

search: adjust grid sizes for community search

4fa7155

subcommunities: remove index.js

d535752

utnapischtim added this to v14 Dec 19, 2025

Conversation

alejandromumo commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alejandromumo Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ptamarit Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alejandromumo Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kpsherva Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ptamarit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alejandromumo commented Oct 23, 2024 •

edited

Loading

alejandromumo Oct 23, 2024 •

edited

Loading

ptamarit Oct 24, 2024 •

edited

Loading

alejandromumo Oct 24, 2024 •

edited

Loading

kpsherva Oct 24, 2024 •

edited

Loading