fix: removes warning about overriding#274
Open
utnapischtim wants to merge 1 commit intoinveniosoftware:masterfrom
Open
fix: removes warning about overriding#274utnapischtim wants to merge 1 commit intoinveniosoftware:masterfrom
utnapischtim wants to merge 1 commit intoinveniosoftware:masterfrom
Conversation
utnapischtim
force-pushed
the
fix-warning
branch
from
7d7c6e9 to
ab745f4
Compare
tmorrell
reviewed
Jul 14, 2025
| # Invalid query strings | ||
| ("$type=search", False), | ||
| ("q=Joan+D'Arc", False), | ||
| ("$type=search", True), |
There was a problem hiding this comment.
This is all a bit confusing to me. Are queries really processed through the oauth2 module?
My summary of this PR is that the character restrictions from queries got copied over to this module, and the correct character restrictions should be loosened to be compliant for oauth2. But it might be nice to change the name of the test or add a bit of documentation to clarify that.
* RuntimeWarning: You are overriding the default OAuthlib "URL encoded" set of valid characters. Make sure that the characters defined in oauthlib.common.urlencoded are indeed limitting your needs.
utnapischtim
force-pushed
the
fix-warning
branch
from
ab745f4 to
cbc3226
Compare
| @@ -589,8 +589,8 @@ def test_resource_auth_methods(provider_fixture): | |||
| ("q=title:TheTitle", True), | |||
| ("q=properly%20encoded%24", True), | |||
| # Invalid query strings | |||
There was a problem hiding this comment.
They are also not invalid anymore, so this should be moved below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set of valid characters. Make sure that the characters defined in
oauthlib.common.urlencoded are indeed limitting your needs.