search: improve with CompositeSuggestQueryParser

[ptamarit]

❤️ Thank you for your contribution!

Description

• Fixes Improve users search results #150 (see details in description)
• Commits
  1. The first commits makes the test assertions more precise
  2. The second commit uses CompositeSuggestQueryParser to improve search results

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

• I'm aware of the code of conduct.
• I've created logical separate commits and followed the commit message format.
• I've added relevant test cases.
• I've added relevant documentation.
• I've marked translation strings.
• I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
• I've NOT included third-party code (copy/pasted source code or new dependencies).
  • If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Frontend

• I've followed the CSS/JS and React guidelines.
• I've followed the web accessibility guidelines.
• I've followed the user interface guidelines.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

1. You license your contribution under the same terms as the current repository’s license.
2. You agree that you have the right to license your contribution under the current repository’s license.

[ptamarit]

fuzziness is applied in CompositeSuggestQueryParser.

[sakshamarora1]

Then the most_fields can also be removed, see PR

[ptamarit]

⚠️
Searching for a username with a dash is still not working well.
For instance, searching from "one-two" seems to search for usernames starting with "one" and starting with "two", and therefore does not find anything.

[kpsherva]

I think this is the issue: text field is split by - https://github.com/inveniosoftware/invenio-users-resources/blob/master/invenio_users_resources/records/mappings/os-v2/users/user-v3.0.0.json#L132
if you search by username.keyword, it should work

[ptamarit]

Awesome, thanks a lot @kpsherva !
2 months later 😅, I confirm that this fixes the issue.

I modified the tests to include a username with a dash, and I added a test showing that usernames with dashes can now be searched properly.

[zzacharo]

This seems like a long standing PR. Can we maybe have a summary of the improvements or maybe a small demo?

[ptamarit]

This seems like a long standing PR. Can we maybe have a summary of the improvements or maybe a small demo?

@zzacharo Sorry for the long wait. I finally found time to get back to it, and it's now ready for prime time.

What is described in the linked issue is a good summary of the problems:

Searching for a person with a common given name and a common family name includes every user with either one of the names and the ranking does not help.
Searching for users with a dash in their usernames behaves the same way.

Happy to give a demo, but the tests are meant to show what changed in this pull request:

1. The test modification in the 2nd commit shows that: before, searching for 2 words was including all the users matching at least 1 of the 2 words. Now, searching for 2 words only includes users matching both words. This means that if a user has a common name, adding more words should help restrict the results and find the proper result.
   
2. The test modification in the 4th commit shows that: before, searching for pub-res would not return the user with the username pub-res. Now, it works as expected.
   

[sakshamarora1]

There is a PR with some changes to the parser: inveniosoftware/invenio-records-resources#608
We should test if this works with the new changes. The rest looks good!

[ptamarit]

There is a PR with some changes to the parser: inveniosoftware/invenio-records-resources#608 We should test if this works with the new changes. The rest looks good!

Thanks for the heads up!
I'll re-run CI when a new version of invenio-records-resources is released (currently v7.0.1), and merge if it is still green.

[carlinmack]

new invenio-records-resources was released (7.0.2) so maybe time to re-run tests? I don't have permission to