feat: add overbooked confirm modal for librarians#669
Merged
kpsherva merged 1 commit intoinveniosoftware:masterfrom Feb 13, 2026
Merged
feat: add overbooked confirm modal for librarians#669kpsherva merged 1 commit intoinveniosoftware:masterfrom
kpsherva merged 1 commit intoinveniosoftware:masterfrom
Conversation
kpsherva
reviewed
Feb 11, 2026
| return; | ||
| } | ||
| } catch (error) { | ||
| console.error('Error checking if the literature is overbooked', error); |
Contributor
There was a problem hiding this comment.
you are missing here also displaying the error to the user - they will not see it in the console, but in case something goes wrong, it it good to inform them about it
kpsherva
reviewed
Feb 11, 2026
src/lib/pages/frontsite/PatronProfile/PatronCurrentLoans/LoanExtendButton.js
Outdated
Show resolved
Hide resolved
kpsherva
reviewed
Feb 11, 2026
src/lib/pages/frontsite/PatronProfile/PatronCurrentLoans/LoanExtendButton.js
Outdated
Show resolved
Hide resolved
875242a to
d5de3ad
Compare
d5de3ad to
d40321e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Librarians and admins can be able to extend their documents without being notified if the document is overbooked.
Added a new modal to warn about overbook:
Request extensionwarning for extending one document:Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: