Skip to content

feat: add overbooked confirm modal for librarians#669

Merged
kpsherva merged 1 commit intoinveniosoftware:masterfrom
zubeydecivelek:overbooked-model
Feb 13, 2026
Merged

feat: add overbooked confirm modal for librarians#669
kpsherva merged 1 commit intoinveniosoftware:masterfrom
zubeydecivelek:overbooked-model

Conversation

@zubeydecivelek
Copy link
Contributor

❤️ Thank you for your contribution!

Description

Librarians and admins can be able to extend their documents without being notified if the document is overbooked.

Added a new modal to warn about overbook:

  • Request extension warning for extending one document:
Screenshot 2026-02-11 at 13 16 23 - `Extend all loans` warning for extending all Screenshot 2026-02-11 at 13 17 06

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

return;
}
} catch (error) {
console.error('Error checking if the literature is overbooked', error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are missing here also displaying the error to the user - they will not see it in the console, but in case something goes wrong, it it good to inform them about it

@zubeydecivelek zubeydecivelek force-pushed the overbooked-model branch 3 times, most recently from 875242a to d5de3ad Compare February 11, 2026 13:09
Copy link
Contributor

@JakobMiesner JakobMiesner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kpsherva kpsherva merged commit 4f8fa37 into inveniosoftware:master Feb 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants