modernize tsconfig, export ESM code #8244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rollup papered over this re-transpiling it to CJS.
dynst
force-pushed
the
esm
branch
2 times, most recently
from
fbce148 to
481c061
Compare
dynst
changed the title
dynst
changed the title
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Nov 28, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Nov 28, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESM code doesn't work when
importstatements don't contain the full file path, extension included. Rollup was re-transpiling it in the 2nd step, so that was fixing it up and the CJS code that Node.js package actually exported worked fine.The ESM code wasn't being exported in
@capacitor/corebecause Node.js doesn't read"module", it only reads"main"and"exports".