Template selection by a subset of tags #584
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(fixes issue ionos-cloud#583).
holmesb
requested review from
65278,
mcbenjemaa,
pborn-ionos and
wikkyk
as code owners
TestsPlease note that running unit and e2e tests requires manual approval from a team member. e2e testsWe use labels to control which e2e tests contexts are run:
ℹ️ Ask a team member to add the requested labels if you don't have enough permissions. |
Contributor
|
Thank you for your contribution. We should be careful with breaking API changes. Please have a look at our friends over at CAPIC. They've hidden this behind the flag |
…mplate lookup. Defaults to "exact", same as current behaviour. "subset" matches templates that have additional tags.
Author
|
Agreed @pborn-ionos. Done. I took the opp to bring tag template selection to the cluster classes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #583
Description of changes:
Make VM templates selectable by a subset of tags. Also made the tag search case-insensitive and de-duped both the wanted and present tag lists.
Testing performed:
Updated tests.