-
Notifications
You must be signed in to change notification settings - Fork 49
feat(iota-e2e-tests): Provide e2e tests for create_auth_info feature #8539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iota-e2e-tests): Provide e2e tests for create_auth_info feature #8539
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. 6 Skipped Deployments
|
0e7bc84
to
9cdd6e9
Compare
Vector related tests are partially turned off for now until we figure out why they break. Ticket: #8525
9cdd6e9
to
48ad690
Compare
crates/iota-e2e-tests/tests/abstract_account/authenticate/sources/option.move
Show resolved
Hide resolved
crates/iota-e2e-tests/tests/abstract_account/authenticate/sources/vector.move
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
crates/iota-e2e-tests/tests/abstract_account/authenticate/sources/object.move
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however should we ensure that all new files have ?
// Copyright (c) 2025 IOTA Stiftung
// SPDX-License-Identifier: Apache-2.0
Fixed in: 86a3bfb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left several comments for consideration; however, it looks good to me overall 👍
crates/iota-e2e-tests/tests/abstract_account/authenticate/sources/signature.move
Show resolved
Hide resolved
crates/iota-e2e-tests/tests/abstract_account/authenticate/sources/vector.move
Show resolved
Hide resolved
This reverts commit 541d836.
fcf940c
into
vm-lang/aa-auth/8116-feature-branch
Description of change
Added a number of e2e tests for the
iota-execution/latest/iota-verifier/src/account_auth_verifier.rs
.Links to any relevant issues
fixes #8414
fixes #8525
How the change has been tested