Skip to content

Conversation

TheMrAI
Copy link
Contributor

@TheMrAI TheMrAI commented Sep 11, 2025

Description of change

Added a number of e2e tests for the iota-execution/latest/iota-verifier/src/account_auth_verifier.rs.

Links to any relevant issues

fixes #8414
fixes #8525

How the change has been tested

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@TheMrAI TheMrAI self-assigned this Sep 11, 2025
Copy link

vercel bot commented Sep 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

6 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
apps-backend Ignored Ignored Preview Oct 1, 2025 10:17am
apps-ui-kit Ignored Ignored Preview Oct 1, 2025 10:17am
iota-evm-bridge Ignored Ignored Preview Oct 1, 2025 10:17am
iota-multisig-toolkit Ignored Ignored Preview Oct 1, 2025 10:17am
rebased-explorer Ignored Ignored Preview Oct 1, 2025 10:17am
wallet-dashboard Ignored Ignored Preview Oct 1, 2025 10:17am

@iota-ci iota-ci added sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team labels Sep 11, 2025
@TheMrAI TheMrAI force-pushed the vm-lang/aa-auth/8414-e2e-for-create-auth-info branch from 0e7bc84 to 9cdd6e9 Compare September 26, 2025 13:02
Vector related tests are partially turned off for now until we figure out why they break.
Ticket: #8525
@TheMrAI TheMrAI force-pushed the vm-lang/aa-auth/8414-e2e-for-create-auth-info branch from 9cdd6e9 to 48ad690 Compare September 26, 2025 13:21
@TheMrAI TheMrAI marked this pull request as ready for review September 29, 2025 11:22
@TheMrAI TheMrAI requested review from a team as code owners September 29, 2025 11:22
@TheMrAI TheMrAI requested review from valeriyr, Dkwcs and theiari and removed request for a team September 29, 2025 11:37
Copy link
Contributor

@miker83z miker83z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Dkwcs Dkwcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however should we ensure that all new files have ?

// Copyright (c) 2025 IOTA Stiftung
// SPDX-License-Identifier: Apache-2.0

@TheMrAI
Copy link
Contributor Author

TheMrAI commented Oct 1, 2025

LGTM, however should we ensure that all new files have ?

// Copyright (c) 2025 IOTA Stiftung
// SPDX-License-Identifier: Apache-2.0

Fixed in: 86a3bfb

Copy link
Contributor

@valeriyr valeriyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left several comments for consideration; however, it looks good to me overall 👍

@TheMrAI TheMrAI merged commit fcf940c into vm-lang/aa-auth/8116-feature-branch Oct 1, 2025
35 of 38 checks passed
@TheMrAI TheMrAI deleted the vm-lang/aa-auth/8414-e2e-for-create-auth-info branch October 1, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants