Skip to content

Conversation

@ipa-rwu
Copy link
Member

@ipa-rwu ipa-rwu commented Oct 6, 2025

This pull request makes targeted improvements to the LaunchFileCompiler_ROS2 class in the ROS system generator, focusing on how remapping is handled for ROS action server interfaces. The most significant change is the enhanced remapping logic for action servers, ensuring that all relevant action-related topics are correctly remapped in the generated launch description. Additionally, the import statements have been reorganized for clarity and maintainability.

Remapping logic improvements:

  • Enhanced the remapping logic in the generate_launch_description method to handle RosActionServerReference interfaces by automatically remapping all associated action topics (e.g., /feedback, /status, /cancel_goal, /get_result, /send_goal) instead of just the main topic. This ensures that all parts of a ROS action are properly redirected in the launch file.

Code organization:

  • Cleaned up and reordered import statements in LaunchFileCompiler_ROS2.xtend for better clarity and to remove unused imports, improving maintainability.

@ipa-rwu ipa-rwu force-pushed the rwu/fix/action_remapping branch from 17625c0 to 8a78d40 Compare October 22, 2025 12:03
@ipa-rwu ipa-rwu force-pushed the rwu/fix/action_remapping branch from 8a78d40 to cafa612 Compare October 22, 2025 13:22
@ipa-nhg
Copy link
Member

ipa-nhg commented Oct 29, 2025

@ipa-rwu many thanks for this fix! :)

@ipa-nhg ipa-nhg merged commit 0b8edca into ipa320:main Oct 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants