fix remap action sever: https://github.com/ros2/ros2/issues/1312#issuecomment-1705521109 #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes targeted improvements to the
LaunchFileCompiler_ROS2class in the ROS system generator, focusing on how remapping is handled for ROS action server interfaces. The most significant change is the enhanced remapping logic for action servers, ensuring that all relevant action-related topics are correctly remapped in the generated launch description. Additionally, the import statements have been reorganized for clarity and maintainability.Remapping logic improvements:
generate_launch_descriptionmethod to handleRosActionServerReferenceinterfaces by automatically remapping all associated action topics (e.g.,/feedback,/status,/cancel_goal,/get_result,/send_goal) instead of just the main topic. This ensures that all parts of a ROS action are properly redirected in the launch file.Code organization:
LaunchFileCompiler_ROS2.xtendfor better clarity and to remove unused imports, improving maintainability.