Skip to content

Conversation

@EGAlberts
Copy link
Contributor

This solves the issue #227 I previously raised.

I made the following changes:

Added four attributes to the ros.model within the QualityOfService object: LeaseDuration, Liveliness, LifeSpan, Deadline.

Defined values for their specification in Ros2.xtext. As the three of these (all except Liveliness), are of type Duration in C++/Python, there is a quirk of allowing specifying an infinite duration (string) or a length of time in nanoseconds (integer). I chose for a string.

Updated the Ros2Validator.xtend to have a rule which makes sure the Duration-based attributes can only hold strings which can be cast to integers, or the keyword 'infinite'.

Please note: PR #222 should be accepted and merged first since this branch continues off of that one.

@ipa-nhg
Copy link
Member

ipa-nhg commented Oct 29, 2025

@EGAlberts many thanks for the changes! It looks great!
Unfortunately, the fact that many files are auto-generated by Eclipse causes many problems when performing clean merges.

@ipa-rwu has fixed the CI system and updated both the Java and Xtext versions. In addition, before any push, she runs a pre-commit command that cleans up white spaces, which causes conflicts in practically any PR that has automatically generated files. I have rebased (#229) your change that still (8ea8f5b) needs to be merged, and this should be the result. Can you confirm that the changes (in files) are correct? --> #229

Thank you so much!

@ipa-nhg
Copy link
Member

ipa-nhg commented Nov 18, 2025

superseded by #229
Many thanks for the changes @EGAlberts 🔝

@ipa-nhg ipa-nhg closed this Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants