Qos Fields completion #228
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue #227 I previously raised.
I made the following changes:
Added four attributes to the ros.model within the QualityOfService object: LeaseDuration, Liveliness, LifeSpan, Deadline.
Defined values for their specification in Ros2.xtext. As the three of these (all except Liveliness), are of type Duration in C++/Python, there is a quirk of allowing specifying an infinite duration (string) or a length of time in nanoseconds (integer). I chose for a string.
Updated the Ros2Validator.xtend to have a rule which makes sure the Duration-based attributes can only hold strings which can be cast to integers, or the keyword 'infinite'.
Please note: PR #222 should be accepted and merged first since this branch continues off of that one.