Upgrade helm to 2.17.0 and kubectl to 1.19.0 #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failed, but it fails in the same way in the other pull requests, so I think this is not related to my change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this pull request bumps Helm to 2.17.0 and kubectl to 1.19.0.
The Helm upgrade is particularly important since 2.14.1 still uses API that was deprecate in kubernetes 1.15 (and Google recently force updated all GKE clusters, so currently all our builds fail).
This is the issue in Helm repository describing the problem: helm/helm#6374
And this is the pull request with the solution (linking directly to a comment saying in which version the fix is to be released): helm/helm#6462 (comment)
Kubectl was upgraded just because the new version is available (if that is the problem, then I can prepare a commit without bumping kubectl).
I'd be really, really glad for merging this (and updating quay.io). Thanks!