Skip to content

Conversation

karlrez
Copy link

@karlrez karlrez commented May 21, 2025

Addresses #2294

Added option to change kubo log level in the settings page.
On startup the log level will be read from local storage and applied to kubo. Log level is set to error level by default.
On startup subsystems are also read from kubo, to be used to validate user input.

Apply log level to all subsystems:
debug
all=debug
*=debug

Or apply specific log level to subsystems:
debug, gc=info, autotls=warn

Form validation checks:

  • Log level is valid option: 'debug' , 'info' , 'warn' , 'error' , 'dpanic' , 'panic' , 'fatal'.
  • Subsystem is valid option.

Valid input:
kubo

Error highlight with placeholder:
error

- Added option to change kubo log level in the settings page.
- On startup the log level will be read from local storage and applied to kubo.
@karlrez karlrez requested a review from a team as a code owner May 21, 2025 02:06
Copy link

welcome bot commented May 21, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@karlrez
Copy link
Author

karlrez commented Jul 31, 2025

apologies, I still have some issues with the e2e tests, I'll reopen once I get this figured out

@karlrez karlrez closed this Jul 31, 2025
@karlrez karlrez reopened this Aug 31, 2025
@lidel
Copy link
Member

lidel commented Sep 4, 2025

Thank you @karlrez, but I believe Diagnostic screen from #2392 is superseding this?

@karlrez
Copy link
Author

karlrez commented Sep 6, 2025

Hi @lidel yea looks like this was already implemented in Diagnostics screen

@karlrez karlrez closed this Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants