Skip to content

Conversation

@FFY00
Copy link

@FFY00 FFY00 commented Mar 18, 2019

With python 2 being discontinued in 9 months could you merge this to keep the project usable? Thanks in advance.

@linusg
Copy link

linusg commented Sep 25, 2019

The provided changes are not enough, for example this needs to be changed as file doesn't exist in Python 3 anymore:

meliae/meliae/loader.py

Lines 530 to 533 in f4bda18

if isinstance(source, file):
input_size = os.fstat(source.fileno()).st_size
else:
input_size = 0

Otherwise it'll die with:

NameError: name 'file' is not defined

Please don't let this project die @isaacl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants