Update README #26
Open
Update README #26
+16
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some typos and grammatical errors
|
I really wonder why such a PR is not merged! |
|
Pinging @shennongmin @zhangabc @hxming123456 @huangxianming |
ekhiw
approved these changes
Mar 27, 2020
|
@ekhiw do you know what is locking for merge? |
|
@scls19fr it also makes me wonder, all PR is correct and has no conflict. |
|
@ekhiw someone grant you as "reviewer"... maybe you can also merge. |
|
@scls19fr no, just review some file and approve, then you become a reviewer. nobody grant me as reviewer |
s-celles
approved these changes
May 3, 2020
|
Oh yes @ekhiw you are right I'm "reviewer" also. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some typos and grammatical errors