Add onTap callback with splash to the centre circle#25
Open
j4m3s wants to merge 2 commits intoitome:masterfrom
Open
Add onTap callback with splash to the centre circle#25j4m3s wants to merge 2 commits intoitome:masterfrom
j4m3s wants to merge 2 commits intoitome:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@itome I love the simplicity of your widget.
In my case though, I need to be able to "capture" clicks so I know when the user has finished with the widget and is ready to close the overlay, so I've added an optional
onTapcallback for the centre circle, and moved from aContainer()to anInkWell()so that there's a splash effect when the circle is clicked (but only if there's an onTap callback).