move stylesheet PopupController.js -> ui.css#17
Merged
Conversation
ivanvit100
approved these changes
May 26, 2026
ivanvit100
left a comment
ivanvit100
left a comment
Owner
There was a problem hiding this comment.
Благодарю за Ваш вклад!
Комментарии по pr некритичные, можно принимать и так.
Comment on lines
228
to
231
| @@ -301,8 +232,6 @@ | |||
Owner
There was a problem hiding this comment.
Поскольку большинство стилей (за исключением display) уже вынесены - возможно стоит вынести и это?
Owner
There was a problem hiding this comment.
Аналогично предыдущему комменатрию: попрошу эти стили также вынести в ui.css
| font-size: 14px; | ||
| margin-left: 8px; | ||
| margin-right: 8px; | ||
| } |
Owner
There was a problem hiding this comment.
Этот селектор уже определён на строке 49. Стоит убрать его оттуда и прописать только здесь.
Comment on lines
+239
to
+241
| #chapterToSelect, #chapterFromSelect { | ||
| border: 2px solid var(--primary-color); | ||
| } |
Owner
There was a problem hiding this comment.
Это правило также фигурирует в отедльных селекторах #chapterFromSelect и #chapterToSelect выше. В таком случае стоит убрать border в верхних определениях, поскольку сейчас это правило избыточно дублируется.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание (Description)
Перенесены(на сколько это возможно) хард стили в css файл.
Перенос js евентов в css hover сломает тесты.
Тип изменений (Type of Changes)
Чеклист (Checklist)
npm test(Tests pass locally)npm run test:coverage(Code coverage has not decreased)