Skip to content

Add button to each channel to enable/disable metering#151

Open
dsheeler wants to merge 2 commits intojack-mixer:mainfrom
dsheeler:feature/disable-metering
Open

Add button to each channel to enable/disable metering#151
dsheeler wants to merge 2 commits intojack-mixer:mainfrom
dsheeler:feature/disable-metering

Conversation

@dsheeler
Copy link
Copy Markdown
Member

This also disables processing of the metering on C side, though that's minimal in the case of non-kmetering. Closes #102.

@dsheeler dsheeler requested a review from SpotlightKid October 26, 2021 09:57
@SpotlightKid
Copy link
Copy Markdown
Contributor

I get the following error message when I open an existing mixer settings XML file:

Traceback (most recent call last):
  File "/home/chris/work/jack_mixer/jack_mixer/channel.py", line 342, in on_metering_toggled
    self.vbox_meter.show()
AttributeError: 'InputChannel' object has no attribute 'vbox_meter'
Traceback (most recent call last):
  File "/home/chris/work/jack_mixer/jack_mixer/channel.py", line 342, in on_metering_toggled
    self.vbox_meter.show()
AttributeError: 'InputChannel' object has no attribute 'vbox_meter'
Traceback (most recent call last):
  File "/home/chris/work/jack_mixer/jack_mixer/channel.py", line 342, in on_metering_toggled
    self.vbox_meter.show()
AttributeError: 'InputChannel' object has no attribute 'vbox_meter'
Traceback (most recent call last):
  File "/home/chris/work/jack_mixer/jack_mixer/channel.py", line 342, in on_metering_toggled
    self.vbox_meter.show()
AttributeError: 'OutputChannel' object has no attribute 'vbox_meter'

@dsheeler
Copy link
Copy Markdown
Member Author

I get the following error message when I open an existing mixer settings XML file:

Traceback (most recent call last):
  File "/home/chris/work/jack_mixer/jack_mixer/channel.py", line 342, in on_metering_toggled
    self.vbox_meter.show()
AttributeError: 'InputChannel' object has no attribute 'vbox_meter'
Traceback (most recent call last):
  File "/home/chris/work/jack_mixer/jack_mixer/channel.py", line 342, in on_metering_toggled
    self.vbox_meter.show()
AttributeError: 'InputChannel' object has no attribute 'vbox_meter'
Traceback (most recent call last):
  File "/home/chris/work/jack_mixer/jack_mixer/channel.py", line 342, in on_metering_toggled
    self.vbox_meter.show()
AttributeError: 'InputChannel' object has no attribute 'vbox_meter'
Traceback (most recent call last):
  File "/home/chris/work/jack_mixer/jack_mixer/channel.py", line 342, in on_metering_toggled
    self.vbox_meter.show()
AttributeError: 'OutputChannel' object has no attribute 'vbox_meter'

@SpotlightKid: fixed it

@SpotlightKid
Copy link
Copy Markdown
Contributor

Repeating what I said on #jack_mixer:

I must say, I don't like the extra button, it takes up additional vertical space and is also rather wide, preventing the channels from being as narrow as they can, when set to narrow width.

Maybe we should think about overhauling the channel buttons layout and put them all in a grid structure, each the same size and maybe image instead of text labels.
We could then also move the prefader meter button there.

@dsheeler
Copy link
Copy Markdown
Member Author

@SpotlightKid Where would we get images for the buttons?

@synthnassizer
Copy link
Copy Markdown
Contributor

synthnassizer commented May 15, 2022 via email

@SpotlightKid
Copy link
Copy Markdown
Contributor

Where would we get images for the buttons?

I don't know, check some of the common web icon fonts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to disable VU meter analysis/displays?

3 participants