feat(ci): add metrics snapshot to query E2E workflow#8189
feat(ci): add metrics snapshot to query E2E workflow#8189hharshhsaini wants to merge 2 commits intojaegertracing:mainfrom
Conversation
Add the verify-metrics-snapshot action step to the query integration test workflow. The test already runs `STORAGE=query make jaeger-v2-storage-integration-test` which uses e2e_integration.go to write .metrics/metrics_snapshot_query.txt — the workflow step just needed to be wired up. Also corrects the step name from 'Memory storage' to 'Query storage' integration tests. Part of jaegertracing#6278. Signed-off-by: hharshhsaini <sainiharsh3311@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Query E2E CI workflow to participate in the repository’s metrics snapshot verification flow, aligning it with other storage backend E2E workflows and fixing an incorrect step label.
Changes:
- Rename the integration test step from “Memory storage” to “Query storage”.
- Add the
verify-metrics-snapshotcomposite action step to upload and (when available) compare.metrics/metrics_snapshot_query.txtagainst the cached baseline.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8189 +/- ##
=======================================
Coverage 95.62% 95.62%
=======================================
Files 318 318
Lines 16771 16771
=======================================
Hits 16038 16038
Misses 578 578
Partials 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CI Summary ReportMetrics Comparison❌ 36 metric change(s) detected View changed metricsmetrics_snapshot_cassandras_4.x_v004_v2_auto metrics_snapshot_cassandras_4.x_v004_v2_manual metrics_snapshot_cassandras_5.x_v004_v2_auto metrics_snapshot_cassandras_5.x_v004_v2_manual metrics_snapshot_elasticsearch_9.x_v2
Code Coverage✅ Coverage 96.8% (baseline 96.8%) ➡️ View CI run | View publish logs |
|
The The |
Which problem is this PR solving?
Description of the changes
verify-metrics-snapshotaction step toci-e2e-query.ymlSTORAGE=query make jaeger-v2-storage-integration-test,which uses
e2e_integration.goto write.metrics/metrics_snapshot_query.txtautomaticallyHow was this change tested?
STORAGE=query make jaeger-v2-storage-integration-testis the same make targetused by other storage backends (badger, memory, etc.) that already have this step, and that
e2e_integration.gowrites.metrics/metrics_snapshot_query.txtfor this storage typemake fmt && make lintpassed locally with 0 issuesChecklist
make lint testAI Usage in this PR (choose one)
See AI Usage Policy.