Skip to content

feat(ci): add metrics snapshot to query E2E workflow#8189

Open
hharshhsaini wants to merge 2 commits intojaegertracing:mainfrom
hharshhsaini:feat/metrics-snapshot-query
Open

feat(ci): add metrics snapshot to query E2E workflow#8189
hharshhsaini wants to merge 2 commits intojaegertracing:mainfrom
hharshhsaini:feat/metrics-snapshot-query

Conversation

@hharshhsaini
Copy link
Contributor

@hharshhsaini hharshhsaini commented Mar 17, 2026

Which problem is this PR solving?

Description of the changes

  • Add verify-metrics-snapshot action step to ci-e2e-query.yml
  • The query integration test already runs STORAGE=query make jaeger-v2-storage-integration-test,
    which uses e2e_integration.go to write .metrics/metrics_snapshot_query.txt automatically
  • The workflow step was just missing this PR wires it up to upload and compare the snapshot against the baseline
  • Also corrects the step name from "Memory storage" to "Query storage" integration tests

How was this change tested?

  • Verified that STORAGE=query make jaeger-v2-storage-integration-test is the same make target
    used by other storage backends (badger, memory, etc.) that already have this step, and that
    e2e_integration.go writes .metrics/metrics_snapshot_query.txt for this storage type
  • make fmt && make lint passed locally with 0 issues

Checklist

AI Usage in this PR (choose one)

See AI Usage Policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Add the verify-metrics-snapshot action step to the query
integration test workflow. The test already runs
`STORAGE=query make jaeger-v2-storage-integration-test`
which uses e2e_integration.go to write
.metrics/metrics_snapshot_query.txt — the workflow step
just needed to be wired up.

Also corrects the step name from 'Memory storage' to
'Query storage' integration tests.

Part of jaegertracing#6278.

Signed-off-by: hharshhsaini <sainiharsh3311@gmail.com>
@hharshhsaini hharshhsaini requested a review from a team as a code owner March 17, 2026 22:47
Copilot AI review requested due to automatic review settings March 17, 2026 22:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Query E2E CI workflow to participate in the repository’s metrics snapshot verification flow, aligning it with other storage backend E2E workflows and fixing an incorrect step label.

Changes:

  • Rename the integration test step from “Memory storage” to “Query storage”.
  • Add the verify-metrics-snapshot composite action step to upload and (when available) compare .metrics/metrics_snapshot_query.txt against the cached baseline.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.62%. Comparing base (af51e32) to head (47944ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8189   +/-   ##
=======================================
  Coverage   95.62%   95.62%           
=======================================
  Files         318      318           
  Lines       16771    16771           
=======================================
  Hits        16038    16038           
  Misses        578      578           
  Partials      155      155           
Flag Coverage Δ
badger_v1 9.05% <ø> (ø)
badger_v2 1.04% <ø> (ø)
cassandra-4.x-v1-manual 13.25% <ø> (ø)
cassandra-4.x-v2-auto 1.03% <ø> (ø)
cassandra-4.x-v2-manual 1.03% <ø> (ø)
cassandra-5.x-v1-manual 13.25% <ø> (ø)
cassandra-5.x-v2-auto 1.03% <ø> (ø)
cassandra-5.x-v2-manual 1.03% <ø> (ø)
clickhouse 1.16% <ø> (ø)
elasticsearch-6.x-v1 16.83% <ø> (ø)
elasticsearch-7.x-v1 16.86% <ø> (ø)
elasticsearch-8.x-v1 17.01% <ø> (ø)
elasticsearch-8.x-v2 1.04% <ø> (ø)
elasticsearch-9.x-v2 1.04% <ø> (-0.05%) ⬇️
grpc_v1 7.79% <ø> (ø)
grpc_v2 1.04% <ø> (ø)
kafka-3.x-v2 1.04% <ø> (ø)
memory_v2 1.04% <ø> (ø)
opensearch-1.x-v1 16.91% <ø> (ø)
opensearch-2.x-v1 16.91% <ø> (ø)
opensearch-2.x-v2 1.04% <ø> (ø)
opensearch-3.x-v2 1.04% <ø> (ø)
query 1.04% <ø> (ø)
tailsampling-processor 0.52% <ø> (ø)
unittests 94.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

CI Summary Report

Metrics Comparison

❌ 36 metric change(s) detected

View changed metrics

metrics_snapshot_cassandras_4.x_v004_v2_auto

metrics_snapshot_cassandras_4.x_v004_v2_manual

metrics_snapshot_cassandras_5.x_v004_v2_auto

metrics_snapshot_cassandras_5.x_v004_v2_manual

metrics_snapshot_elasticsearch_9.x_v2
3 added

  • jaeger_storage_latency_seconds
  • jaeger_storage_requests
  • rpc_server_call_duration_seconds

Code Coverage

✅ Coverage 96.8% (baseline 96.8%)

➡️ View CI run | View publish logs
2026-03-18 13:16:47 UTC

@hharshhsaini
Copy link
Contributor Author

The CI Summary Report failure is expected for this PR. metrics_summary.sh errors when zero diff_*.txt files are found — but since this is the first time the query snapshot is being uploaded (no baseline exists on main yet), the verify-metrics-snapshot action correctly skips comparison and produces no diff file. This will work correctly once the first baseline is established after merge to main.

The Verify PR Label failure is also fixed -> added the changelog:enhancement label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants