feat: add metrics backwards-compatibility CI framework#8204
Draft
Amaan729 wants to merge 2 commits intojaegertracing:mainfrom
Draft
feat: add metrics backwards-compatibility CI framework#8204Amaan729 wants to merge 2 commits intojaegertracing:mainfrom
Amaan729 wants to merge 2 commits intojaegertracing:mainfrom
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6278
Summary
Implements the first incremental slice of the metrics backwards-compatibility framework requested in #6278.
What this PR adds
.github/actions/verify-metrics-snapshot/— new composite actionA reusable GitHub Actions composite action that:
curls the/metricsendpoint.The action is already referenced in
ci-e2e-memory.yamlvia:testdata/metrics/— baseline snapshot directoryEmpty directory with a README explaining the workflow. Baseline
.txtfiles are committed here after the first successful CI run.What's intentionally out of scope for this PR
curl-based approach is simpler and has no build-time dependency.How to establish the first baseline
After this PR is merged and a workflow run completes:
Testing
actionlint.Checklist
.txtfiles (will be committed in a follow-up after first CI run)