Open
Conversation
- Add RelaxationU, RelaxationP, RelaxationH, RelaxationTurbulence, RelaxationRho properties to solver object under a Relaxation group - Wire properties through fvSolution template for both steady-state and transient (non-Final) relaxation factors - Update all test reference fvSolution files to match template changes - Bump version to 1.34.18
Collaborator
|
Could I request to name these "URelaxation, pRelaxation, rhoRelaxation etc, so that the capitalisation of the variable can more naturally match the actual variable naming? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add RelaxationU, RelaxationP, RelaxationH, RelaxationTurbulence, RelaxationRho properties to solver object under a Relaxation group
Update all test reference fvSolution files to match template changes
Let me know if you prefer not to add this or put it in different place.

The resulting relaxation factors will be written to fvSolutions like this for example.
All test pass except #262 which need to be merge first.