Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/green-geckos-teach.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@browser-ai/web-llm": patch
---

fix: type requestOptions & fix providerOptions key lookup
22 changes: 14 additions & 8 deletions packages/vercel/web-llm/src/chat/web-llm-language-model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { convertToWebLLMMessages } from "../utils/convert-to-webllm-messages";

import {
AppConfig,
ChatCompletionRequestNonStreaming,
ChatCompletionRequestStreaming,
CreateWebWorkerMLCEngine,
InitProgressReport,
Expand Down Expand Up @@ -266,20 +267,25 @@ export class WebLLMLanguageModel implements LanguageModelV3 {
const messages = convertToWebLLMMessages(prompt);

// Build request options
const requestOptions: any = {
const requestOptions: ChatCompletionRequestNonStreaming = {
messages,
temperature,
max_tokens: maxOutputTokens,
top_p: topP,
seed,
};

if (providerOptions?.extra_body) {
const webLLMOptions = providerOptions?.[this.provider];
const extraBody = webLLMOptions?.extra_body as
| Record<string, unknown>
| undefined;
if (extraBody) {
// https://webllm.mlc.ai/docs/user/api_reference.html#generationconfig
requestOptions.extra_body = {
enable_thinking: providerOptions.extra_body.enable_thinking,
enable_latency_breakdown:
providerOptions.extra_body.enable_latency_breakdown,
enable_thinking: extraBody.enable_thinking as boolean | undefined,
enable_latency_breakdown: extraBody.enable_latency_breakdown as
| boolean
| undefined,
};
}

Expand Down Expand Up @@ -400,7 +406,7 @@ export class WebLLMLanguageModel implements LanguageModelV3 {
reasoning: undefined,
},
},
request: { body: { messages: promptMessages, ...requestOptions } },
request: { body: { ...requestOptions, messages: promptMessages } },
warnings,
};
}
Expand Down Expand Up @@ -439,7 +445,7 @@ export class WebLLMLanguageModel implements LanguageModelV3 {
total: response.usage?.total_tokens,
},
},
request: { body: { messages: promptMessages, ...requestOptions } },
request: { body: { ...requestOptions, messages: promptMessages } },
warnings,
};
} catch (error) {
Expand Down Expand Up @@ -688,7 +694,7 @@ export class WebLLMLanguageModel implements LanguageModelV3 {

return {
stream,
request: { body: { messages: promptMessages, ...requestOptions } },
request: { body: { ...requestOptions, messages: promptMessages } },
};
}
}
29 changes: 29 additions & 0 deletions packages/vercel/web-llm/test/web-llm-language-model.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,35 @@ describe("WebLLMLanguageModel", () => {
}),
);
});

it("should forward extra_body provider options to the request", async () => {
mockChatCompletionsCreate.mockResolvedValue({
choices: [{ message: { content: "ok" }, finish_reason: "stop" }],
usage: { prompt_tokens: 5, completion_tokens: 2, total_tokens: 7 },
});

const model = new WebLLMLanguageModel("test-model");
await model.doGenerate({
prompt: [{ role: "user", content: [{ type: "text", text: "hi" }] }],
providerOptions: {
"web-llm": {
extra_body: {
enable_thinking: true,
enable_latency_breakdown: false,
},
},
},
});

expect(mockChatCompletionsCreate).toHaveBeenCalledWith(
expect.objectContaining({
extra_body: {
enable_thinking: true,
enable_latency_breakdown: false,
},
}),
);
});
});

describe("doStream", () => {
Expand Down