Cover more material in scopes section - #434
Merged
Merged
Conversation
|
Looks really nice as well imo! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address #431.
I think the points mentioned in the issue were covered. Please let me know if I missed something.
In addition, the suggested changes include:
Some specific points regarding mutation / removal of the original text:
I replaced the sentence:
with:
I hope that captured the spirit. I didn't really get what "expand" meant in the original 😅
I removed a portion that recommends the use of
letover that ofdoanddeffor at least two reasons:letand then goes on to say that usingdoanddefis fine, so it seemed that just not making the recommendation communicates almost the same idea...and that's shorter!defoverletin some situations [2].[1] Disclosure: it's true that I'm one of those people...and you're going to have to work to convince me otherwise :)
[2] It might be of interest to eventually collect together more specifics on when to use one approach over the other, but I think this PR is too narrow to contain it :P