feat: Add Muon optimizer for FSDP training#23
Draft
nguyenhoangthuan99 wants to merge 1 commit intomainfrom
Draft
feat: Add Muon optimizer for FSDP training#23nguyenhoangthuan99 wants to merge 1 commit intomainfrom
nguyenhoangthuan99 wants to merge 1 commit intomainfrom
Conversation
- Add verl/optim/muon.py with Muon and MuonWithAdamW optimizer classes - Add verl/optim/__init__.py to export the optimizer classes - Add verl/trainer/config/optim/muon.yaml for Hydra config - Add examples/muon/config/ppo_trainer_muon.yaml example training config - Update verl/workers/config/optimizer.py to add MuonOptimizerConfig and handle Muon in build_optimizer() Muon (MomentUm Orthogonalized by Newton-Schulz) is designed for 2D matrix parameters in neural networks. It should be combined with AdamW for non-matrix parameters (embeddings, biases, gains, etc.). Reference: https://github.com/KellerJordan/Muon Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Muon (MomentUm Orthogonalized by Newton-Schulz) is designed for 2D matrix parameters in neural networks. It should be combined with AdamW for non-matrix parameters (embeddings, biases, gains, etc.).
Reference: https://github.com/KellerJordan/Muon
What does this PR do?
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)