fix: gracefully handle missing RT metadata during RT tolerance filtering#52
fix: gracefully handle missing RT metadata during RT tolerance filtering#52janusson wants to merge 2 commits into
Conversation
Modifies the `rt_tolerance` filtering logic in `SimilarityEngine.search` to use `_is_missing()` for parsing metadata. It will now safely ignore strings like 'None' or 'N/A' that are often populated in `matchms` spectra instead of crashing or raising a `ValueError`. Added unit tests for this functionality. Co-authored-by: janusson <34246713+janusson@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
@jules I have made significant changes to the codebase since this PR was opened. Please re-evaluate your implementation based on the current state of the main branch and update the code to ensure it still fits the current architecture. Please adjust to resolve branch conflicts. |
I have fetched the latest changes from the main branch and rebased my PR branch. The core of my logic changes from this PR (using |
Co-authored-by: janusson <34246713+janusson@users.noreply.github.com>
src/MassFlow/similarity.pyto correctly parseq_rtandref_rtduring filtering.tests/test_similarity.pyfocusing on string/missing value parsing and valid RT filtering paths.PR created automatically by Jules for task 5829458267677549992 started by @janusson