feat(similarity): add safe retention time tolerance filtering#53
Conversation
- Updated `similarity.py` to use `_is_missing()` to safely handle query and reference retention times (prevents `ValueError` on strings like 'N/A'). - Added `test_rt_tolerance_filtering()` in `tests/test_similarity.py` to verify logic. - The `rt_tolerance` field was already present in `SimilarityConfig` from previous state. Co-authored-by: janusson <34246713+janusson@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Adds robust parsing of retention time strings and missing values before applying
rt_tolerancefiltering in the similarity search. Handles instances where metadata may contain missing/None values as string literals (e.g. "N/A", "None") by using the pre-existing_is_missing()helper. Included unit tests for strict filtering logic.PR created automatically by Jules for task 9931654286799291530 started by @janusson