Skip to content

fix: rename duplicate test_rt_tolerance_filtering functions#55

Open
janusson wants to merge 1 commit into
mainfrom
fix-lint-duplicate-tests-10341868546285334692
Open

fix: rename duplicate test_rt_tolerance_filtering functions#55
janusson wants to merge 1 commit into
mainfrom
fix-lint-duplicate-tests-10341868546285334692

Conversation

@janusson

@janusson janusson commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Fix ruff linting failure caused by redefining test_rt_tolerance_filtering multiple times in tests/test_similarity.py. I renamed the duplicates to test_rt_tolerance_filtering_strict and test_rt_tolerance_filtering_exact so that all the assertions and test coverage are preserved while allowing the pipeline checks to pass.


PR created automatically by Jules for task 10341868546285334692 started by @janusson

    The tests/test_similarity.py file contained multiple definitions of the
    `test_rt_tolerance_filtering` function. This caused the `ruff` linter to
    fail with `F811 Redefinition of unused test_rt_tolerance_filtering`.
    Renamed the duplicate functions to preserve test coverage and fix the
    linting error. All checks and tests now pass globally.

Co-authored-by: janusson <34246713+janusson@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant