Skip to content

[Bugfix][ALSA]Fixes a bug where snd_pcm_writei will hang the mix thread#364

Open
bradc6 wants to merge 1 commit intojarikomppa:masterfrom
bradc6:bugfix/ALSAHang
Open

[Bugfix][ALSA]Fixes a bug where snd_pcm_writei will hang the mix thread#364
bradc6 wants to merge 1 commit intojarikomppa:masterfrom
bradc6:bugfix/ALSAHang

Conversation

@bradc6
Copy link

@bradc6 bradc6 commented Jun 22, 2023

This bugfix goes after 2 issues;

  1. The channels was hard coded to 2 instead of what was passed in (Otherwise probably should return an error)
  2. Ensure that there is IO available to write to the ALSA device before we write, otherwise we will hang. This behavior occurs for me when using pulseaudio's ALSA plugin.

@bradc6 bradc6 changed the title Fixes a bug where snd_pcm_writei will hang the mix thread [Bugfix]Fixes a bug where snd_pcm_writei will hang the mix thread Jun 22, 2023
@bradc6 bradc6 changed the title [Bugfix]Fixes a bug where snd_pcm_writei will hang the mix thread [Bugfix][ALSA]Fixes a bug where snd_pcm_writei will hang the mix thread Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant