Open
Conversation
* Change typeof equaltiy (==) with strict equality (===)
jgonggrijp
requested changes
Aug 2, 2023
Collaborator
There was a problem hiding this comment.
Thank you for going through the trouble to contribute.
I'm not necessarily against this change, but a microbenchmark of the type you referenced is meaningless. It does not represent real world situations and provides no justification for a change to the code, even if you get a big difference (which is not even the case in these benchmarks; the difference is less than the uncertainty).
Please try the Offen benchmark with d122213 as the baseline ref and 6c6bcb1 as the comparison ref, and report back here with your results. If we see a significant improvement, we will continue the review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why;
https://www.measurethat.net/Benchmarks/Show/19/0/which-equals-operator-vs-is-faster
https://www.measurethat.net/Benchmarks/Show/26565/0/typeof-eqeq-vs-typeof-eqeqeq