Skip to content

Conversation

@JorisGoosen
Copy link
Contributor

@JorisGoosen JorisGoosen commented Oct 31, 2025

https://support.jasp-services.com/SCG-Chemicals/SCG_Chemicals_Public_Company_Limited/issues/16

@vandenman Ill open this as a draft to have it pinned somewhere.

image

is added to ploteditor, the lowest line is a dummy line where an edit results in a new line.

It sends some extra json in the plotediting as follows:

"editOptions" : 
		{
			"error" : "success",
			"references" : 
			[
				{
					"horizontal" : false,
					"point" : true,
					"text" : "A very  fancy label",
					"x" : 0.0,
					"y" : 0.0
				}
			],
			"resetPlot" : false,
			"xAxis" : 
			{
				etcetera....

…icals/SCG_Chemicals_Public_Company_Limited/issues/16

ok the editing isnt working out very well

the tabbar should not move with the content..

open the resultsmenu in the right place even when zooming in or out...

make the ploteditor tabs a lot better

open first tab on show

ah the rolenames were messing up the width

🤡

typeselecting works

now to get the position entry to work
@JorisGoosen JorisGoosen requested a review from vandenman October 31, 2025 14:38
@JorisGoosen JorisGoosen marked this pull request as draft October 31, 2025 14:38
@vandenman
Copy link
Contributor

Nice! This is indeed everything I needed to make the R side work:

screenshot_referencelines_1 screenshot_referencelines_2

Code is at https://github.com/jasp-stats/jaspGraphs/tree/referenceLines

Not sure what your workflow is, but you can test this by building jaspDescriptives as a devmodule with renv and then installing jaspGraphs in that renv project with renv::install("path_to_jaspGraphs_checkout") or renv::install("jasp-stats/jaspGraphs@referenceLines").

We can definitely still improve some stuff, but this is already a good start. Perhaps we should have a brief chat to determine what is in scope of this feature and what is not, because it's very easy for me to come up with 100+ tweaks to this (e.g., adding options for label placement, nudging, point color/ shape, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants