Jython compatibility issue#316
Open
mbettan wants to merge 1 commit into
Open
Conversation
Relating to issue jcgregorio#300 0.9.2 release didn't fix Jython compatibility issue Proposing fix : ```from socket import socket``` instead of import socket
Author
|
Hello @jcgregorio - Any feedbacks on the proposed change? |
Author
|
Any updates please? |
Author
|
@jcgregorio - Any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Relating to the issue discovered here #300
Http lib 0.9.2 release didn't fix Jython compatibility issue.
Proposing following fix :
from socket import socketinstead ofimport socketinto socks.py@tmatsuo what do you think? Any better idea ?
Thanks for very much. It's really important to have it fully compatible with Jython