Fix hostname validation logic for custom self-signed gov't certificate#318
Open
reingart wants to merge 2 commits into
Open
Fix hostname validation logic for custom self-signed gov't certificate#318reingart wants to merge 2 commits into
reingart wants to merge 2 commits into
Conversation
Use subject if subjectAltName doesn't contains DNS entries (this could happen with old/broken certs). Now the logic is similar to the one used in Python's SSL match_hostname: https://hg.python.org/cpython/file/2.7/Lib/ssl.py#l238 The return value should be backward compatible (None if no hostname is found at all)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation in _GetValidHostsForCert (no DNS specified, commonName in subject not honored) raises an Exception with a ARBA certificate for https://cot.arba.gov.ar/:
But, it should work, at least
gnutls-clidoes:This patch implements a logic similar to Python's SSL match_hostname, but being backward compatible.
A custom test and the CA certificate was added too.
Let me know if you need the same for Python3