support adding AES keytab entries for Active Directory#484
Open
rilott wants to merge 3 commits intojcmturner:masterfrom
Open
support adding AES keytab entries for Active Directory#484rilott wants to merge 3 commits intojcmturner:masterfrom
rilott wants to merge 3 commits intojcmturner:masterfrom
Conversation
|
The methods worked for me as the salt for the tickets emitted by Active Directory comes with the format And gokrb5 tries to generate a salt with cname.GetSalt method, concatenating all the Names of the SPN which is wrong, ending with something like this: With the salt like that, the decryption will fail. |
This was referenced Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft active directory uses it's own AES salt for keytab entries. This PR adds a new function
AddActiveDirectoryComputerAccountEntrywhich handles this, and doesn't modify the normalAddEntryfunction.I tried to add this with minimal code changes/duplication.
Partially fixes #416 (computer accounts only)
All tests pass
Thanks!
Ross