fix: spnego client reqs forever incrementing#561
Open
gycc7253 wants to merge 1 commit intojcmturner:masterfrom
Open
fix: spnego client reqs forever incrementing#561gycc7253 wants to merge 1 commit intojcmturner:masterfrom
gycc7253 wants to merge 1 commit intojcmturner:masterfrom
Conversation
gycc7253
force-pushed
the
spnego.fix-redirect-reqs
branch
from
8671aae to
a7514ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background:
Currently, spnego Client maintains a list of redirect requests in a slice of
reqsthat is only incrementing and never cleared, in Client.Do() function, if reqs > 10, itreturn resp, errors.New("stopped after 10 redirects").Problem:
This will lead to a consequence that the client will always fail to handle redirect after it has accumutively handled more than 10 redirects since its instantiation.
Solution:
Clears this reqs list when a request has received a response that is neither a redirect, nor unauthorized response that requires negotiation.