feat: mark extensions as dynamically loadable#121
Open
Conversation
Both extensions in this plugin are stateless and safe for dynamic loading. Setting dynamicLoadable to YES allows Jenkins to hot-load the plugin without prompting the user to restart, improving the plugin installation experience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dynamicLoadable = YesNoMaybe.YESon both@Extensionannotations (CCTrayXmlActionFactoryandCCTrayXmlPageDecorator)Why
Without an explicit
dynamicLoadablevalue, Jenkins defaults toMAYBE, which prompts users to choose between restarting Jenkins or dynamically loading the plugin during installation. Since both extensions are stateless and have no complex initialization, they are safe for dynamic loading. SettingYESlets Jenkins hot-load the plugin without prompting, improving the installation experience.Test plan
mvn verifypasses