Add option to suppress merge commits diff in showRevision#1250
Open
rscurciel wants to merge 1 commit intojenkinsci:masterfrom
Open
Add option to suppress merge commits diff in showRevision#1250rscurciel wants to merge 1 commit intojenkinsci:masterfrom
rscurciel wants to merge 1 commit intojenkinsci:masterfrom
Conversation
Author
|
Hi @MarkEWaite I just wanted to check if there's anything else I could do to help move this forward. Let me know if any further change are needed. Thanks!. |
Contributor
Thanks for asking. I'm working on other topics that are higher priority for me right now. It will likely be several weeks before I can look at this. |
|
Hi @MarkEWaite , were you able to make any progress yet on this issue? Is there something we can help to get it resolved? We are also facing lots of issues with merge commits, and this pull request seems the solution for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I create this PR to fix the issues mentioned in the PR#750.
The code changes are basically the same that in the closed PR but adding tests (thanks @anatoly-spb).
The issues are
The goal of this pull request is to add the option to suppress merge commits diff in the
showRevisionmethods, the feature is disabled by default to maintain backward compatibility.I plan to create a pull request in the git plugin too to add the option to use this configuration in the
Polling ignores commits in certain pathsextension once this is merged.Testing done
I've run all the unit test and the steps specified in the Contributing document.
I've also tested it in Jenkins with git plugin installed too.
Submitter checklist