Migrate from EE 8 to EE 9 #153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plugin uses RequestImpl internals directly (casting StaplerRequest), which broke when Stapler was updated to EE 9 in jenkinsci/stapler#482. This change also updates dependencies to current versions where needed. The access modifier checker had to be disabled because this uses some Messages from the core.
jmairboeck
commented
May 27, 2025
Comment on lines
-251
to
-393
| /** | ||
| * Returns the last build. | ||
| * | ||
| * @return the build or null | ||
| */ | ||
| @SuppressWarnings(UNUSED) | ||
| @CheckForNull | ||
| @Exported | ||
| public Run getLastBuild() { | ||
| Run retVal = null; | ||
| for (Job job : getAllJobs()) { | ||
| retVal = takeLast(retVal, job.getLastBuild()); | ||
| } | ||
| return retVal; | ||
| } | ||
|
|
||
| /** | ||
| * Returns the oldest build in the record. | ||
| * | ||
| * @return the build or null | ||
| */ | ||
| @SuppressWarnings(UNUSED) | ||
| @CheckForNull | ||
| @Exported | ||
| public Run getFirstBuild() { | ||
| Run retVal = null; | ||
| for (Job job : getAllJobs()) { | ||
| Run run = job.getFirstBuild(); | ||
| if (run != null && (retVal == null || run.getTimestamp().before(retVal.getTimestamp()))) { | ||
| retVal = run; | ||
| } | ||
| } | ||
| return retVal; | ||
| } | ||
|
|
||
| /** | ||
| * Returns the last successful build, if any. Otherwise null. A successful build would include | ||
| * either {@link Result#SUCCESS} or {@link Result#UNSTABLE}. | ||
| * | ||
| * @return the build or null | ||
| * @see #getLastStableBuild() | ||
| */ | ||
| @SuppressWarnings(UNUSED) | ||
| @CheckForNull | ||
| @Exported | ||
| public Run getLastSuccessfulBuild() { | ||
| Run retVal = null; | ||
| for (Job job : getAllJobs()) { | ||
| retVal = takeLast(retVal, job.getLastSuccessfulBuild()); | ||
| } | ||
| return retVal; | ||
| } | ||
|
|
||
| /** | ||
| * Returns the last build that was anything but stable, if any. Otherwise null. | ||
| * | ||
| * @return the build or null | ||
| * @see #getLastSuccessfulBuild | ||
| */ | ||
| @SuppressWarnings(UNUSED) | ||
| @CheckForNull | ||
| @Exported | ||
| public Run getLastUnsuccessfulBuild() { | ||
| Run retVal = null; | ||
| for (Job job : getAllJobs()) { | ||
| retVal = takeLast(retVal, job.getLastUnsuccessfulBuild()); | ||
| } | ||
| return retVal; | ||
| } | ||
|
|
||
| /** | ||
| * Returns the last unstable build, if any. Otherwise null. | ||
| * | ||
| * @return the build or null | ||
| * @see #getLastSuccessfulBuild | ||
| */ | ||
| @SuppressWarnings(UNUSED) | ||
| @CheckForNull | ||
| @Exported | ||
| public Run getLastUnstableBuild() { | ||
| Run retVal = null; | ||
| for (Job job : getAllJobs()) { | ||
| retVal = takeLast(retVal, job.getLastUnstableBuild()); | ||
| } | ||
| return retVal; | ||
| } | ||
|
|
||
| /** | ||
| * Returns the last stable build, if any. Otherwise null. | ||
| * | ||
| * @return the build or null | ||
| * @see #getLastSuccessfulBuild | ||
| */ | ||
| @SuppressWarnings(UNUSED) | ||
| @CheckForNull | ||
| @Exported | ||
| public Run getLastStableBuild() { | ||
| Run retVal = null; | ||
| for (Job job : getAllJobs()) { | ||
| retVal = takeLast(retVal, job.getLastStableBuild()); | ||
| } | ||
| return retVal; | ||
| } | ||
|
|
||
| /** | ||
| * Returns the last failed build, if any. Otherwise null. | ||
| * | ||
| * @return the build or null | ||
| */ | ||
| @SuppressWarnings(UNUSED) | ||
| @CheckForNull | ||
| @Exported | ||
| public Run getLastFailedBuild() { | ||
| Run retVal = null; | ||
| for (Job job : getAllJobs()) { | ||
| retVal = takeLast(retVal, job.getLastFailedBuild()); | ||
| } | ||
| return retVal; | ||
| } | ||
|
|
||
| /** | ||
| * Returns the last completed build, if any. Otherwise null. | ||
| * | ||
| * @return the build or null | ||
| */ | ||
| @SuppressWarnings(UNUSED) | ||
| @CheckForNull | ||
| @Exported | ||
| public Run getLastCompletedBuild() { | ||
| Run retVal = null; | ||
| for (Job job : getAllJobs()) { | ||
| retVal = takeLast(retVal, job.getLastCompletedBuild()); | ||
| } | ||
| return retVal; | ||
| } | ||
|
|
||
| @CheckForNull | ||
| private Run takeLast(Run run1, Run run2) { | ||
| if (run2 != null && (run1 == null || run2.getTimestamp().after(run1.getTimestamp()))) { | ||
| return run2; | ||
| } | ||
| return run1; | ||
| } |
Author
There was a problem hiding this comment.
I think that these methods aren't needed any more. They seem to be replaced with jenkinsci/cloudbees-folder-plugin#87. (They would at least require some changes to still build.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin uses RequestImpl internals directly (casting StaplerRequest), which broke when Stapler was updated to EE 9 in jenkinsci/stapler#482.
This change also updates dependencies to current versions where needed.
The access modifier checker had to be disabled because this uses some Messages from the core.
Testing done
Unit tests ran successfully.
I installed the locally built plugin in our Jenkins instance (running version 2.504.1) and was able to successfully update the job configuration of the jobs which are using this. This failed before with a ClassCastException in TemplateStaplerRequestWrapper.
Submitter checklist