Skip to content

Remove commons-lang2 usage - #368

Open
gbhat618 wants to merge 1 commit into
jenkinsci:masterfrom
gbhat618:lang2-removal
Open

Remove commons-lang2 usage#368
gbhat618 wants to merge 1 commit into
jenkinsci:masterfrom
gbhat618:lang2-removal

Conversation

@gbhat618

Copy link
Copy Markdown

Commons-lang2 will be soon removed from Jenkins core jenkinsci/jenkins#26105; remove the lang2 usages from here to prepare. Usages are simple hence replacing with just jdk apis.

import java.util.List;

import static jakarta.servlet.http.HttpServletResponse.SC_NOT_FOUND;
import static org.apache.commons.lang.StringUtils.isNotEmpty;

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead import

@gbhat618

Copy link
Copy Markdown
Author

need to label as developer to get a release.

@gbhat618

Copy link
Copy Markdown
Author

Hi @alecharp,
can you help add label developer and merge this PR. ty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants