Skip to content

fix: Enable compile with SDK >= 9 #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartelink merged 1 commit into from
Feb 9, 2026
Merged

fix: Enable compile with SDK >= 9 #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ The `Unreleased` section name is replaced by the expected version of next releas

## [Unreleased]

### Changed

- Targeted`FSharp.Core` v `8.0.403` (To handle SDK >= 9 being strict on `RequireQualifiedAccess` with `Struct`) [#270](https://github.com/jet/propulsion/pull/270)

<a name="3.0.0"></a>
## [3.0.0] - 2025-09-23

Expand Down
6 changes: 3 additions & 3 deletions src/Propulsion/Propulsion.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<!-- NOTE FSharp.Core dep is implies by what `FSharp.Control.TaskSeq` dictates; see below -->
<!-- We want to depend on as old a version as possible. That would be 6.0.1, but we need v8 to be able to do RequireQualifiedAccess on a Struct with a V9+ compiler -->
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
<PackageValidationBaselineVersion>3.0.0</PackageValidationBaselineVersion>
</PropertyGroup>
Expand All @@ -31,9 +31,9 @@

<ItemGroup>
<PackageReference Include="MinVer" Version="5.0.0" PrivateAssets="All" />

<!-- Min FSharp.Core version that allows RequireQualifiedAccess on structs -->
<PackageReference Include="FSharp.Core" Version="8.0.403" />
<PackageReference Include="FsCodec" Version="3.1.0" />
<!-- NOTE this transitively implies a min FSharp.Core 6.0.1 dependency (was 6.0.0 before) -->
<PackageReference Include="FSharp.Control.TaskSeq" Version="0.4.0" />
<PackageReference Include="MathNet.Numerics" Version="4.15.0" />
<PackageReference Include="Serilog" Version="2.7.1" />
Expand Down
2 changes: 0 additions & 2 deletions tests/Propulsion.Tests/Propulsion.Tests.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@
<ItemGroup>
<PackageReference Include="FsCheck.Xunit" Version="3.0.0-rc3" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
<!-- Pin requirement for at least 6.0.6 in one of the tests by requesting same as Propulsion.DynamoStore will require-->
<PackageReference Include="FSharp.Core" Version="6.0.7" ExcludeAssets="contentfiles" />
<PackageReference Include="unquote" Version="6.1.0" />
<PackageReference Include="xunit" Version="2.7.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.3">
Expand Down
Loading