Skip to content

merge eslint-plugin-better Fixes #30#32

Open
graingert wants to merge 34 commits intojfmengels:masterfrom
graingert:merge-plugin-better
Open

merge eslint-plugin-better Fixes #30#32
graingert wants to merge 34 commits intojfmengels:masterfrom
graingert:merge-plugin-better

Conversation

@graingert
Copy link
Copy Markdown
Collaborator

@graingert graingert commented Aug 4, 2017

Fixes #30

@graingert graingert force-pushed the merge-plugin-better branch 2 times, most recently from 266b281 to 8ce009c Compare August 4, 2017 18:02
@graingert
Copy link
Copy Markdown
Collaborator Author

@idmitriev @jfmengels thoughts?

@graingert
Copy link
Copy Markdown
Collaborator Author

@nickmccurdy ^

@graingert graingert force-pushed the merge-plugin-better branch from 8ce009c to 8b8fa79 Compare August 7, 2017 09:58
@graingert graingert force-pushed the merge-plugin-better branch from 8b8fa79 to 361f228 Compare August 7, 2017 10:20
@graingert graingert force-pushed the merge-plugin-better branch from 70afb01 to 64fb977 Compare August 7, 2017 10:31
@graingert
Copy link
Copy Markdown
Collaborator Author

@bodil
@idmitriev
@jfmengels

I've invited you all to contribute to https://github.com/eslint-plugin-cleanjs/eslint-plugin-cleanjs which includes the ruleset from eslint-config-cleanjs (excluding eslint-plugin-import) and this PR.

@graingert
Copy link
Copy Markdown
Collaborator Author

@jfmengels Ideally I'd like to merge back into eslint-plugin-fp, because it has a much better name on npm.

Copy link
Copy Markdown
Contributor

@nickserv nickserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just read this, looks great thanks! I only skimmed the new rule source files but I'm assuming they're the same as eslint-plugin-better in master. It's ready to merge as far as I'm aware.

I also noticed that none of the new rules are marked as recommended. I think this is good for transitional purposes, though it would be great to change the default recommended rules and draft a major release after this is merged.

@stephanschubert
Copy link
Copy Markdown

Any update on this?

@graingert
Copy link
Copy Markdown
Collaborator Author

@nickmccurdy looks like it's started to conflict

@graingert
Copy link
Copy Markdown
Collaborator Author

@jfmengles can I get access to this repo and npm publish?

@jfmengels
Copy link
Copy Markdown
Owner

@graingert I give them to you quite a while ago 🤔

@graingert
Copy link
Copy Markdown
Collaborator Author

Oh really ok, I'll sort all this out asap then

@j-oshb
Copy link
Copy Markdown

j-oshb commented Jan 24, 2019

It would be nice to see docs for the new rules, in the same style as eslint-plugin-fp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants