Support MemberExpressions in no-mutating-methods allowedObjects#54
Open
raineorshine wants to merge 1 commit intojfmengels:masterfrom
Open
Support MemberExpressions in no-mutating-methods allowedObjects#54raineorshine wants to merge 1 commit intojfmengels:masterfrom
raineorshine wants to merge 1 commit intojfmengels:masterfrom
Conversation
raineorshine
force-pushed
the
allowedObjects
branch
from
e40caaa to
32bbf59
Compare
raineorshine
added a commit
to a-thousand-worlds/a-thousand-worlds
that referenced
this pull request
Jan 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
no-mutating-methods, theallowedObjectsoption currently only works onIdentifiertypes, notMemberExpressiontypes. This PR adds support forMemberExpressiontypes.For example, this currently reports an error:
Use Case
The standard way of navigating to a new route in vue-router is with
this.$router.push(...). Setting"allowedObjects": ["$router"]does not work as expected. There is no way to getno-mutating-methodsto ignore this with the current implementation.Additional Nodes
This is a breaking change. I can add a different option to avoid breaking, but arguably the existing option should have always functioned this way.