Recreate the AST with functors #99
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 19, 2022
Open
Ericson2314
force-pushed
the
functored-ast
branch
from
e9d9f5e to
8ca89de
Compare
Ericson2314
force-pushed
the
functored-ast
branch
from
8ca89de to
6a3bff7
Compare
|
Oops, I had messed up the cabal file. Should be OK now. |
|
CI is failing for this and the associated PR on pandoc, so it's hard to evaluate. |
|
OK will fix tests and CPP |
Ericson2314
force-pushed
the
functored-ast
branch
from
6a3bff7 to
c9b8875
Compare
|
Oops, there was something I forgot to commit that already fixed it! |
Fixes jgm#98 See the issue for details of why this is useful
Could use `driving via newtype` for this but that wouldn't work with older GHCs.
Ericson2314
force-pushed
the
functored-ast
branch
from
c9b8875 to
bb9f022
Compare
|
OK added a JSON deriving option so hopefully the newtypes don't introduced extra fluff. That was what was making the tests fail. |
|
Oh good this does pass now. |
Ericson2314
force-pushed
the
functored-ast
branch
from
3ff2a78 to
bb9f022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98
See the issue for details of why this is useful