Skip to content

Conversation

@mb21
Copy link
Collaborator

@mb21 mb21 commented Sep 16, 2018

depends on jgm/pandoc-types#51

@mb21
Copy link
Collaborator Author

mb21 commented Sep 28, 2018

Okay, this is now changed to include the new functions in Text.Pandoc.Writers.Shared instead of pandoc-types.

@mb21 mb21 force-pushed the use-lookup-meta branch from 18f75e5 to a7e0e30 Compare October 4, 2018 07:36
@mb21
Copy link
Collaborator Author

mb21 commented Oct 4, 2018

@jgm, due to d7263a7, there was a conflict again. You added metaValueToString there, analogous to the metaValueToInlines functions which I removed in favour of the lookupMetaInlines. (I don't really feel strongly either way, but most usage makes this variant simpler.)

So I rebased once more. Would be really good to merge this, since otherwise people will continue adding stuff that transforms the metadata inconsistently to string/inline/block/bool, etc. like just happened now.

@mb21 mb21 force-pushed the use-lookup-meta branch from a7e0e30 to b0cebbf Compare October 4, 2018 13:24
@jgm
Copy link
Owner

jgm commented Oct 4, 2018

@mb21, sorry about that. I'll merge!

@jgm jgm merged commit 600034d into jgm:master Oct 4, 2018
@mb21 mb21 deleted the use-lookup-meta branch October 5, 2018 06:00
@mb21
Copy link
Collaborator Author

mb21 commented Oct 5, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants