rewriting strcasechr to compare multiple bytes at once#174
Open
333-9 wants to merge 1 commit intojhawthorn:masterfrom
Open
rewriting strcasechr to compare multiple bytes at once#174333-9 wants to merge 1 commit intojhawthorn:masterfrom
333-9 wants to merge 1 commit intojhawthorn:masterfrom
Conversation
vigoux
added a commit
to vigoux/azy.nvim
that referenced
this pull request
Sep 18, 2022
This merges jhawthorn/fzy#174 into the the embedded fzy UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing some basic pointer/bit magic to compare 4 bytes for a requested character.
The code compares 4 bytes at a time, since this is faster than comparing 8 bytes
when the target character is in the first 32 bytes (on average).
But the most significant speedup is probably a call to strchr when the requested
character is a utf-8 byte (may be extended to all non-alphabetical characters).