fix(ssh): add support for modern SSH key algorithms#608
fix(ssh): add support for modern SSH key algorithms#608jdubois merged 6 commits intojhipster:mainfrom
Conversation
- Added support for ed25519 and rsa-sha2 SSH deploy keys - Verified locally that connections now work using the new SSH key algorithms supported by GitHub - Built Docker image and tested it on existing ECR - Verified by deploying to current ECS cluster, replacing old image with the freshly built one Fix jhipster#607
|
Fixes #607 – added support for ed25519 and rsa-sha2 keys. Tested locally and ready for review. |
.dockerignore
Outdated
| @@ -1,2 +1,2 @@ | |||
| target | |||
| #target | |||
There was a problem hiding this comment.
Hi,
About the Dockerfile and .dockerignore adjustments:
The change in .dockerignore was needed only so the newly created Dockerfile could successfully build the test Docker image. I used that image in my own ECS development cluster to verify the new JHipster Registry version.
If this extra Dockerfile is not required in your official build process, then both the .dockerignore change can be reverted and the Dockerfile itself can be removed, since you will anyway be building and publishing the official image to DockerHub.
There was a problem hiding this comment.
Reverted .dockerignore and removed Dockerfile form commit. Like it was before...
…on: XML Language Support by Red Hat
… Extension: XML Language Support by Red Hat" This reverts commit 4f682c9.
|
@alexlukic is this PR ready to be merged on your side? If yes, I'll have another look |
|
@jdubois Yes it is, I made all suggestions that mraible asked. It is completely ready for merge from my side. |
|
LGTM @alexlukic , thank you!!
|
|
@mraible we'll need to do a new release of JHipster Registry, do you want me to do it independently from a JHipster release? Or do you want to release everything at once next time? |
I have submitted a $300 bug bounty expense on the JHipster OpenCollective: Also, thanks a lot @jdubois and @mraible for the quick review, guidance, and support! |
|
@jdubois It's probably best to do a release as the next JHipster release might be awhile. Tagging @DanielFran for his opinion. |
|
I see the GitHub Action is outdated and a release will be complicated -> I'm having a look, and I'll probably work directly on the main branch as I want to fix the GitHub Action, so don't be surprised |
|
Release v7.5.0 done (I also upgraded several dependencies in the process), and I just opened a PR to the main project in order to include this version in the next release: jhipster/generator-jhipster#30934 |
4 participants
Added support for ed25519 and rsa-sha2 SSH deploy keys
Verified locally that connections now work using the new SSH key algorithms supported by GitHub
Built Docker image and tested it on existing ECR
Verified by deploying to current ECS cluster, replacing old image with the freshly built one
Fix #607
Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed